forgejo: remove no longer needed preBuild phase (noop) #313227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This slipped through the 1.21.11-1 -> 7.0.0 bump in 6c359d6. Upstream made this a noop with a deprecation warning instead of a hard fail in https://codeberg.org/forgejo/forgejo/pulls/2864. Note: In that PR (it's commit) they link to nixpkgs as downstream consumer of it (`build/merge-forgejo-locales.go`). ~~~ # Before Running phase: buildPhase NOT NEEDED: THIS IS A NOOP AS OF Forgejo 7.0 BUT KEPT FOR BACKWARD COMPATIBILITY Building subPackage ./. # After Running phase: buildPhase Building subPackage ./. ~~~ Upstream commit: https://codeberg.org/forgejo/forgejo/commit/6647e4d53f04f8d5585090c7f0cf266713542b4b
|
@ofborg eval |
adamcstephens
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This slipped through the 1.21.11-1 -> 7.0.0 bump in #306341 (6c359d6).
Upstream made this a noop with a deprecation warning instead of a hard fail in https://codeberg.org/forgejo/forgejo/pulls/2864.
Note: In that PR (it's commit) they link to nixpkgs as downstream consumer of it (
build/merge-forgejo-locales.go).Upstream commit: https://codeberg.org/forgejo/forgejo/commit/6647e4d53f04f8d5585090c7f0cf266713542b4b
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)