signal-desktop: init at 1.0.35 #31335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
NickHu
requested changes
Nov 6, 2017
|
|
||
| # Patch signal | ||
| patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $out/libexec/signal-desktop | ||
| patchelf --set-rpath ${rpath}:$out/libexec $out/libexec/signal-desktop |
There was a problem hiding this comment.
Perhaps better to just use one patchelf invocation
| xlibs.libxcb | ||
| zulu | ||
| zulu8 | ||
| ] + ":${stdenv.cc.cc.lib}/lib64"; |
There was a problem hiding this comment.
Quite a few unnecessary imports here, see #31337 for a minimal set
| unpackPhase = "true"; | ||
| buildCommand = '' | ||
| mkdir -p $out | ||
| dpkg -x $src $out |
There was a problem hiding this comment.
I think this should be in the unpackPhase
| ''; | ||
|
|
||
| meta = { | ||
| description = "Signal messenger for the desktop."; |
There was a problem hiding this comment.
I think the branding is Signal Desktop or something like that. Better to ask someone who knows?
There was a problem hiding this comment.
I used what you had for the description in your PR.
|
Thank you for the review @NickHu! |
|
Thanks guys! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The Signal Desktop application was recently released and the community has no derivation for it.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)