ark-pixel-font: unbreak by suppressing debug logs, and remove extraneous builds #313748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous builds For some reason build.py builds a lot of stuff that is completely unrelated to the fonts themselves. Let's remove that! Also the script is generating so much debug output that Hydra refuses to evaluate the package — my fix is to pipe the output through grep to filter out any log message below INFO, but I wish the script has a built-in way to set the log level so that I don't have to do this hack
pluiedev
added
0.kind: ZHF Fixes
|
Result of 1 package built:
|
|
Actually TakWolf/ark-pixel-font#31 has all the fixes I want, including customizable log levels and even a parallel build option... It's completely beyond me why the maintainer hasn't merged it yet, but... |
risicle
approved these changes
May 24, 2024
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
For some reason build.py builds a lot of stuff that is completely unrelated to the fonts themselves. Let's remove that!
Also the script is generating so much debug output that Hydra refuses to evaluate the package — my fix is to pipe the output through grep to filter out any log message below INFO, but I wish the script has a built-in way to set the log level so that I don't have to do this hack
ZHF #309482
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.