Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains: 2024.1 EAP -> 2024.1.3 #313940

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

zlepper
Copy link
Contributor

@zlepper zlepper commented May 23, 2024

Description of changes

jetbrains.datagrip: 2024.1.2 -> 2024.1.3
jetbrains.gateway: 2024.1.1 -> 2024.1.2
jetbrains.goland: 2024.1.1 -> 2024.1.2
jetbrains.idea-community: 2024.1.1 -> 2024.1.2
jetbrains.idea-ultimate: 2024.1.1 -> 2024.1.2
jetbrains.rider: 2024.1.1 -> 2024.1.2
jetbrains.ruby-mine: 2024.1.1 -> 2024.1.2
jetbrains.rust-rover: 2024.1 EAP -> 2024.1
jetbrains.webstorm: 2024.1.2 -> 2024.1.3

and updated plugins.

via running ./bin/update_bin.py

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@phip1611
Copy link
Contributor

phip1611 commented May 23, 2024

Great! Note to all Jetbrains users:

Starting with this version (and the corresponding plugins), one has to

@ryansname
Copy link
Contributor

@zlepper Are you able to rerun the update script to catch Intellij IDEA version 2024.1.2 -> https://blog.jetbrains.com/idea/2024/05/intellij-idea-2024-1-2/

@zlepper
Copy link
Contributor Author

zlepper commented May 27, 2024

@zlepper Are you able to rerun the update script to catch Intellij IDEA version 2024.1.2 -> https://blog.jetbrains.com/idea/2024/05/intellij-idea-2024-1-2/

Done, updated set is now:

jetbrains.datagrip: 2024.1.2 -> 2024.1.3
jetbrains.gateway: 2024.1.1 -> 2024.1.2
jetbrains.goland: 2024.1.1 -> 2024.1.2
jetbrains.idea-community: 2024.1.1 -> 2024.1.2
jetbrains.idea-ultimate: 2024.1.1 -> 2024.1.2
jetbrains.rider: 2024.1.1 -> 2024.1.2
jetbrains.ruby-mine: 2024.1.1 -> 2024.1.2
jetbrains.rust-rover: 2024.1 EAP -> 2024.1
jetbrains.webstorm: 2024.1.2 -> 2024.1.3

@ryansname
Copy link
Contributor

ryansname commented May 28, 2024

Thanks, IntelliJ 2024.1.2 / x86_64-linux looks to be working

@JohnRTitor
Copy link
Contributor

Nice, any chance we could get RustRover packaged for Nix?

@zlepper
Copy link
Contributor Author

zlepper commented May 28, 2024

Nice, any chance we could get RustRover packaged for Nix?

I don't understand what you mean? It's already packaged? This is just updating it to the latest build?

@JohnRTitor
Copy link
Contributor

Nevermind, for some reason I have been searching rustrover instead of the actual package name rust-rover on Nixpkgs.

Copy link
Contributor

@niknetniko niknetniko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 313940 run on x86_64-linux 1

10 packages built:
  • jetbrains.datagrip
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea-community (jetbrains.idea-community-src)
  • jetbrains.idea-community-bin
  • jetbrains.idea-ultimate
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

I manually tested idea-ultimate and everything works.

@JohnRTitor JohnRTitor requested a review from wegank June 6, 2024 08:05
@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 313940 run on x86_64-linux 1

10 packages built:
  • jetbrains.datagrip
  • jetbrains.gateway
  • jetbrains.goland
  • jetbrains.idea-community (jetbrains.idea-community-src)
  • jetbrains.idea-community-bin
  • jetbrains.idea-ultimate
  • jetbrains.rider
  • jetbrains.ruby-mine
  • jetbrains.rust-rover
  • jetbrains.webstorm

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update PHPstorm as well?

jetbrains.clion: 2024.1.1 -> 2024.1.2
jetbrains.datagrip: 2024.1.2 -> 2024.1.3
jetbrains.gateway: 2024.1.1 -> 2024.1.2
jetbrains.goland: 2024.1.1 -> 2024.1.2
jetbrains.idea-community: 2024.1.1 -> 2024.1.2
jetbrains.idea-ultimate: 2024.1.1 -> 2024.1.2
jetbrains.phpstorm: 2024.1.1 -> 2024.1.2
jetbrains.pycharm-community: 2024.1.1 -> 2024.1.2
jetbrains.pycharm-professional: 2024.1.1 -> 2024.1.2
jetbrains.rider: 2024.1.1 -> 2024.1.2
jetbrains.ruby-mine: 2024.1.1 -> 2024.1.2
jetbrains.rust-rover: 2024.1 EAP -> 2024.1
jetbrains.webstorm: 2024.1.2 -> 2024.1.3
jetbrains.writerside: 2024.1 EAP -> 2024.1 EAP
@zlepper
Copy link
Contributor Author

zlepper commented Jun 6, 2024

Could you update PHPstorm as well?

Done.

@JohnRTitor
Copy link
Contributor

Another thing I would add: GitHub Copilot plugin login seems to fail with PHPStorm or RustRover.
But it works on IDEs installed via jetbrains-toolbox. Could you check? I am guessing this could be a permission error.

image

image

@zlepper
Copy link
Contributor Author

zlepper commented Jun 6, 2024

Another thing I would add: GitHub Copilot plugin login seems to fail with PHPStorm or RustRover. But it works on IDEs installed via jetbrains-toolbox. Could you check? I am guessing this could be a permission error.

image

image

Just tested using a build of RustRover from this PR:
image

I assume you are using the Copilot plugin from the IDE marketplace/plugin settings and not from nix based on your description? Because this is copilot installed from the Marketplace/plugin settings.

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved.

I am still having issues with Copilot, even though I installed it in nix way and cleared the state. It's not a blocker though.

@wegank wegank merged commit a096ced into NixOS:master Jun 7, 2024
20 checks passed
@JohnRTitor JohnRTitor added the backport release-24.05 Backport PR automatically label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants