Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin3d: unstable-2022-07-27 -> 4.0.2 #314053

Merged
merged 1 commit into from
Jun 23, 2024
Merged

Conversation

afh
Copy link
Member

@afh afh commented May 23, 2024

Description of changes

  • Update to 4.0.2
  • Fix darwin build

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4000

@afh
Copy link
Member Author

afh commented Jun 2, 2024

Friendly ping to @gebner and @viric on this 🙂

@afh
Copy link
Member Author

afh commented Jun 23, 2024

@JohnRTitor you've been helpful in reviewing and merging a few other of my PRs recently, maybe you have some time and interest to devote your expertise on this one?

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, building it at the moment

@JohnRTitor JohnRTitor merged commit 62498d0 into NixOS:master Jun 23, 2024
27 checks passed
@afh afh deleted the update-coin3d branch June 23, 2024 16:30
@afh
Copy link
Member Author

afh commented Jun 23, 2024

Thanks for your help on this, @JohnRTitor, very much appreciated! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants