Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.plugp100: init at 5.1.3 #314566

Merged
merged 2 commits into from
May 28, 2024
Merged

python3Packages.plugp100: init at 5.1.3 #314566

merged 2 commits into from
May 28, 2024

Conversation

pyle
Copy link
Contributor

@pyle pyle commented May 25, 2024

Description of changes

Adds plugp100 python module in preperation for adding custom home-assistant component for TP-Link Tapo devices (component)

Notes:

  • Disabled integration tests as they require a device on the network.
  • Disabled some unit tests that were already failing.
  • Added self as maintainer (no other suitable person?)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nbraud nbraud merged commit 5a7b442 into NixOS:master May 28, 2024
25 checks passed
@pyle
Copy link
Contributor Author

pyle commented Jun 1, 2024

Thanks!

@pyle pyle deleted the plugp100 branch June 1, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants