-
-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
bant: init at 0.1.5 #314680
bant: init at 0.1.5 #314680
Conversation
2b6940e
to
92f52b4
Compare
afc7da7
to
65040fd
Compare
This is a little tool I wrote that helps exploring bazel projects and also provides some dependency cleaning features. However it seems to not work well to build as package on nix. I suspect this is because I am using bzlmod ? Observed
Are bzlmod projects not well-supported currently ? |
65040fd
to
a59bb58
Compare
a59bb58
to
d61a801
Compare
Maybe folks from @NixOS/bazel know some way to get this unstuck ? |
d61a801
to
97aaa76
Compare
New This can be made work with something @lromor has been working on: if the external bzlmod repository is bulit as fixed derivation, it can be passed to bazel with it not attempting to download the registry again after the build-phase: Something like that would probably need to go into (I could compile this PR when I patched in @lromor 's change to |
For now I'll prepare a PR that uses |
@hzeller , I found a simpler way:
Note that I need a different hash, not sure why. |
Perfect, thanks @lromor ! I think you should create a fresh |
Chatted offline with @lromor : he'll prepare a nixpkgs pull request that includes the bazel registry as part of the derivation. |
Description of changes
From the README : Utility to support projects using the bazel build system, in particular C++ projects.
Upstream v0.1.5 Release Notes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 馃憤 reaction to pull requests you find important.