Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam-chrootenv: add iana-etc, fixes #25443 #31480

Merged
merged 1 commit into from Nov 10, 2017

Conversation

DIzFer
Copy link
Contributor

@DIzFer DIzFer commented Nov 10, 2017

Motivation for this change

Both Borderlands 2 and Borderlands: The Pre-Sequel silently crash when downloading hotfixes, as documented in #25443. This appears to be the same bug as flathub/com.valvesoftware.Steam#5, which is fixed by having a populated /etc/services.

Things done

Adding iana-etc to the chrootenv's environment makes this crash go away. I may again be messing up where the package should be added...

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@lukateras
Copy link
Member

Thank you! We might soon hit nearly 100% compatibility with Steam games in this pace :-)

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just rebuilt steam-run with this change and I can verify that after this change /etc/services is properly populated, and that it wasn't before. I don't have Borderlands 2, but I plan to buy it soon, I'll test it then. Again, thanks <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants