New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php: Fix php pcre by using external lib #31526
Conversation
Alternative candidate for the fix: #31525 |
@vcunat is the only one who has voiced their opinion so far, preferring using the external pcre library (which I'm leaning towards as well.) I've added a NixOS test that blocks the channel advancement (I think?) that ensures similar issues don't arise again without us noticing. I could use a review on this, since I'm new to messing with the release files. :) |
This should block the big channels and not the small ones. Given that we do have |
@@ -91,6 +91,12 @@ let | |||
configureFlags = [ "--enable-pcntl" ]; | |||
}; | |||
|
|||
# pcre functionality is tested in nixos/tests/php-pcre.nix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be more noticeable to say at the top of the file that there is nixos php test available.
I agree with @vcunat that we should use external pcre, both because unbundling is more maintanable and because the other approach as it is implemented in php is fragile. It bothers me that you add |
@orivej That is a good point. I can simply set it to |
@orivej How about 7e17685 ? |
Thank you. |
Released in b76e7f8 |
(cherry picked from commit 8562538)
(cherry picked from commit 2fc2063)
Motivation for this change
Fixes #31451
Fixes #31499
Things done
Tested using https://gist.github.com/srhb/2d9f5354cdf16c96ec3356f4c5383303
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)