tdf: init at 0-unstable-2024-05-29 #315575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
It's probably worth making an issue on upstream to add a license |
Seems good to me! Thank you. I'll wait for the LICENSE addition as someone also on reddit post pointed out |
|
Yeah when asked usually people just slap a MIT on it |
|
@luftmensch-luftmensch license was added. mpl2.0 |
luftmensch-luftmensch
force-pushed
the
tdf_0-unstable-2024-05-29
branch
from
3e07faa
to
7d236ca
Compare
Applied changes! |
Gerg-L
reviewed
May 30, 2024
luftmensch-luftmensch
force-pushed
the
tdf_0-unstable-2024-05-29
branch
from
7d236ca
to
84a8053
Compare
|
Result of 1 package built:
|
Gerg-L
approved these changes
May 30, 2024
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1705 |
luftmensch-luftmensch
force-pushed
the
tdf_0-unstable-2024-05-29
branch
from
84a8053
to
e897944
Compare
SuperSandro2000
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
tdf is a tui-based PDF viewer written in rust
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.