-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ccache: 4.9.1 -> 4.10 #315714
ccache: 4.9.1 -> 4.10 #315714
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4004 |
ece541b
to
8a20018
Compare
cab2eb8
to
ca839dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 315714
run on x86_64-linux 1
1 package marked as broken and skipped:
- redpanda-server
9 packages built:
- ccache
- ccache.man
- ccacheStdenv
- ccacheWrapper
- monophony
- python311Packages.nuitka
- python311Packages.nuitka.dist
- python312Packages.nuitka
- python312Packages.nuitka.dist
Result of nixpkgs-review pr 315714
run on x86_64-darwin 1
8 packages built:
- ccache
- ccache.man
- ccacheStdenv
- ccacheWrapper
- python311Packages.nuitka
- python311Packages.nuitka.dist
- python312Packages.nuitka
- python312Packages.nuitka.dist
Dependencies now necessary to compile `ccache` added: `doctest`, `fmt`, `hiredis`, `xxHash`.
Oh oops - my bad. Looking at this again today, I was wrong about using I'll just push those changes myself to avoid another back and forth on the code review. Then this should be good to merge once all the checks are green! |
@Nanotwerp @kira-bruneau I'm now getting a ccache build failure on aarch64-darwin, complaining about the hash from this PR:
|
Opened #316520 |
Description of changes
Updates
ccache
from version4.9.1
to version4.10
. Thepackage.nix
was formatted withnixfmt-rfc-style
. Dependencies now necessary to compileccache
added:doctest
,fmt
,hiredis
,xxHash
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.