Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anki: Switch dependency to beautifulsoup-3 #31581

Merged
merged 1 commit into from Nov 13, 2017

Conversation

adisbladis
Copy link
Member

The current upstream development version is using 4 but the release
version is still using 3.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The current upstream development version is using 4 but the release
version is still using 3.
@disassembler
Copy link
Member

Requesting review from @FRidh we typically don't keep multiple versions of python packages around, but if it's required for this one, he'd know if this is the right way to do it.

@adisbladis
Copy link
Member Author

adisbladis commented Nov 13, 2017

@disassembler I introduced a regression in anki by bumping up the package version to beatifulsoup4 and this was only caught at runtime, not by the build.

This PR is reinstating the old dependency (but locally in anki instead of python-packages.nix).

@disassembler disassembler merged commit 10d02b7 into NixOS:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants