caddy: 2.7.6 -> 2.8.4 #316076
caddy: 2.7.6 -> 2.8.4 #316076
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4010 |
There was a problem hiding this comment.
I'm not sure we should actively migrate code over to another code formatter. At least, I'd leave it up to the individual package maintainers for now.
Squashing it into the same commit that does a bump makes this very hard to review. Please make it two separate commits at least, or leave the reformatting up to the maintainers, or a tree wide formatting, if that happens at some point.
Done! I made them separate commits. I apologize for the inconvenience. |
|
Thanks! Bump changes LGTM, but let's have the package maintainers decide about the PR. |
There was a problem hiding this comment.
Oh and while you are at it, could you also please add at the very least two links to each of the version's release notes as hinted in our contributing guidelines?
Nanotwerp
force-pushed
the
caddy-up
branch
3 times, most recently
from
c6570fb
to
10f8d96
Compare
|
CI check fails because of a trailing comma and still missing the release note links in the commit message. It's fine if you only change the CI check failure. I can squash-merge your commit and fix the commit message that way. |
Nanotwerp
force-pushed
the
caddy-up
branch
2 times, most recently
from
f3a59d2
to
19110f0
Compare
All done! Sorry for the formatting issues and thousands of force-pushes! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1707 |
|
Bumped up to |
Nanotwerp
force-pushed
the
caddy-up
branch
2 times, most recently
from
893df42
to
9377dd3
Compare
Nanotwerp
force-pushed
the
caddy-up
branch
2 times, most recently
from
e964834
to
5584b1a
Compare
|
You previously had a However, We could merge
No worries, even thousands of force-pushes are fine. |
|
Updated to |
There was a problem hiding this comment.
How about the following commit message instead:
caddy: 2.7.6 -> 2.8.4
Starting with v2.8.0, Caddy recommends building with the `nobadger`
build tag.
The build tag makes go skip the compilation of the badger-db
implementation from smallstep/nosql, as it isn't used by Caddy and thus
slightly shrinks the resulting binary size.
https://github.com/caddyserver/caddy/releases/tag/v2.8.4
https://github.com/caddyserver/caddy/releases/tag/v2.8.3
https://github.com/caddyserver/caddy/releases/tag/v2.8.2
https://github.com/caddyserver/caddy/releases/tag/v2.8.1
https://github.com/caddyserver/caddy/releases/tag/v2.8.0
diff: https://github.com/caddyserver/caddy/compare/v2.7.6...v2.8.4
|
Please check the failing CI output, you now introduced trailing whitespace. |
Starting with v2.8.0, Caddy recommends building with the `nobadger` build tag. The build tag makes go skip the compilation of the badger-db implementation from smallstep/nosql, as it isn't used by Caddy and thus slightly shrinks the resulting binary size. https://github.com/caddyserver/caddy/releases/tag/v2.8.4 https://github.com/caddyserver/caddy/releases/tag/v2.8.3 https://github.com/caddyserver/caddy/releases/tag/v2.8.2 https://github.com/caddyserver/caddy/releases/tag/v2.8.1 https://github.com/caddyserver/caddy/releases/tag/v2.8.0 diff: caddyserver/caddy@v2.7.6...v2.8.4
Fixed. The text editor I use needs to get |
Description of changes
Updates
caddyfrom version2.7.6to version2.8.4. This commit also adds thenobadgerbuild tag, which prevents thebadger-dbimplementation ofNoSQLfrom being compiled. This reduces the binary size ofcaddy, and is being used bycaddy's upstream ever since2.8.0.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.