-
-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
asfa: init at 0.10.0 #316730
asfa: init at 0.10.0 #316730
Conversation
We do not use Semantic Versioning. Reword the commit according to the Contributing Guidelines - the one you checked. |
Hey! Thanks for taking your time to contribute. Could you update the PR title/commit message to use the commit message conventions listed inside pkgs/README.md? Edit: looks like I was too slow in sending the message :) |
c39ef48
to
f24f60f
Compare
f24f60f
to
50b745e
Compare
* adapt build dependencies according to helpful comments in NixOS/nixpkgs#316730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some additional change suggestions.
Also, consider formatting the file using nixfmt-rfc-style
.
It's the soon-to-be default across nixpkgs
.
Doing this helps avoid unnecessarily big diffs when the tree-wide formatting happens sometime in the future.
85cd632
to
99c57da
Compare
99c57da
to
e8c7e9e
Compare
e8c7e9e
to
f434c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f434c85
to
47efd86
Compare
47efd86
to
db112da
Compare
db112da
to
7fc3a68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides, LGTM
7fc3a68
to
ae383a6
Compare
ae383a6
to
502b1ac
Compare
Description of changes
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
), also working my personal setupAdd a 馃憤 reaction to pull requests you find important.