Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

asfa: init at 0.10.0 #316730

Merged
merged 1 commit into from
Jul 1, 2024
Merged

asfa: init at 0.10.0 #316730

merged 1 commit into from
Jul 1, 2024

Conversation

obreitwi
Copy link
Contributor

@obreitwi obreitwi commented Jun 2, 2024

Description of changes

  • add new package: asfa at latest version

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/), also working my personal setup
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member

We do not use Semantic Versioning.

Reword the commit according to the Contributing Guidelines - the one you checked.

@TomaSajt
Copy link
Contributor

TomaSajt commented Jun 2, 2024

Hey! Thanks for taking your time to contribute.

Could you update the PR title/commit message to use the commit message conventions listed inside pkgs/README.md?
It would be something like: <package>: init at <version>

Edit: looks like I was too slow in sending the message :)

@obreitwi obreitwi changed the title feat: add package asfa asfa: init at 0.10.0 Jun 2, 2024
obreitwi added a commit to obreitwi/asfa that referenced this pull request Jun 2, 2024
* adapt build dependencies according to helpful comments in
  NixOS/nixpkgs#316730
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some additional change suggestions.

Also, consider formatting the file using nixfmt-rfc-style.
It's the soon-to-be default across nixpkgs.
Doing this helps avoid unnecessarily big diffs when the tree-wide formatting happens sometime in the future.

pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
@obreitwi obreitwi force-pushed the ojb/asfa/add-pkg branch 3 times, most recently from 85cd632 to 99c57da Compare June 4, 2024 20:52
Copy link
Contributor

@TomaSajt TomaSajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkgs/by-name/as/asfa/package.nix Show resolved Hide resolved
pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, LGTM

pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/as/asfa/package.nix Outdated Show resolved Hide resolved
@wegank wegank merged commit dfb7d5b into NixOS:master Jul 1, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants