Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

glrnvim: init at 1.4.0 #317006

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Conversation

aacebedo
Copy link
Contributor

@aacebedo aacebedo commented Jun 3, 2024

Description of changes

Add this tool that helps with the integration of nvim as a default editor in a system.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4022

pkgs/by-name/gl/glrnvim/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glrnvim/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glrnvim/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glrnvim/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/gl/glrnvim/package.nix Outdated Show resolved Hide resolved
@aacebedo
Copy link
Contributor Author

@SuperSandro2000 can you merge this if the modifications are correct?

'';

meta = {
description = "really fast & stable neovim GUI could be accelerated by GPU";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "really fast & stable neovim GUI could be accelerated by GPU";
description = "Really fast & stable neovim GUI which could be accelerated by GPU";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax here doesn't look quite right, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@aacebedo
Copy link
Contributor Author

@Aleksanaa can you merge?

@aacebedo
Copy link
Contributor Author

aacebedo commented Jul 1, 2024

@Aleksanaa is it ok for you now I have corrected the comment?

@Aleksanaa Aleksanaa merged commit dd3a525 into NixOS:master Jul 1, 2024
26 checks passed
@superherointj
Copy link
Contributor

superherointj commented Jul 1, 2024

glrnvim builds for Darwin are failing:

Options:

  1. Darwin build is fixed.
  2. Darwin is marked broken.
  3. Darwin is removed from platforms.
  4. Do nothing and let hydra continuously rebuild this and watch Darwin builds get even slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants