-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kcl: refactor #317827
kcl: refactor #317827
Conversation
1a6c067
to
7cc4b2e
Compare
dunno, why I have
Locally |
91198d5
to
8deb7b0
Compare
Looks like fixed after importing |
f5ec6ca
to
edaf378
Compare
edaf378
to
e92c574
Compare
I leave only |
Description of changes
Hello! Currently, kcl doesn't work properly
Example
The core problem is that
kcl
is a Go program that is coupled withkclvm_cli
binary to work with kcl itself. The dependency graph looks like this:kcl
->kclvm_cli
->kclvm
, wherekclvm
is a library with KCL Language Implementationkclvm_cli
is a low-level cli for workingkcl
is a wrapper aroundkclvm_cli
which used to work with kcl filesSo I did these on this PR:
kclvm
andkclvm_cli
packages (mostly got from here)kcl-cli
to justkcl
. I'm afraid that it would be super confusing to have three KCL-related packages where two of them havecli
in their names. In all examples the documentation always references the binary askcl
, so I believe it's better to call the main package exactlykcl
too.kcl
packageThings done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)@Peefy take a look on that too, pls.
Add a 👍 reaction to pull requests you find important.
Close #310770