Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmd: merge into single file #317845

Closed
wants to merge 1 commit into from
Closed

dmd: merge into single file #317845

wants to merge 1 commit into from

Conversation

jtbx
Copy link
Contributor

@jtbx jtbx commented Jun 6, 2024

Description of changes

Merge the dmd package into a single file. The bootstrap package has also been merged into its own file.

Also add meta.changelog.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4059

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4088

@CyberShadow
Copy link
Contributor

Would there be any interest in bootstrapping DMD from source? I've implemented that in Digger.

@jtbx
Copy link
Contributor Author

jtbx commented Jul 5, 2024

Sure I'd be up for that. Do you think we could use the existing LDC package to bootstrap it?

@CyberShadow
Copy link
Contributor

Do you think we could use the existing LDC package to bootstrap it?

I haven't thought of that. Do you think LDC is simpler to bootstrap from source than DMD?

GDC would probably be easiest to bootstrap from source, as it was the longest running pure-C++ implementation of D.

@jtbx
Copy link
Contributor Author

jtbx commented Jul 5, 2024

I haven't thought of that. Do you think LDC is simpler to bootstrap from source than DMD?

I thought LDC would be easier due to it not using DMD's D backend. But yes I agree GDC would probably be the best option here.

@jtbx jtbx mentioned this pull request Jul 6, 2024
13 tasks
@jtbx
Copy link
Contributor Author

jtbx commented Jul 6, 2024

Superseded by #324982

@jtbx jtbx closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants