Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

{sourcery,vscode-extensions.sourcery.sourcery}: 1.16.0 -> 1.19.0 #318527

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Jun 9, 2024

Description of changes

This PR bumps the version of the sourcery packages

Looks like the libxcrypt-legacy dep was replaced by zlib

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Pandapip1
Copy link
Contributor

Is there any place where this dependency change is documented?

@TomaSajt
Copy link
Contributor Author

Is there any place where this dependency change is documented?

The derivation uses autoPatchelfHook to auto-detect dependencies of prebuilt binaries. If you remove zlib from buildInputs, it's gonna complain about missing deps.

Copy link
Contributor

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.

@superherointj superherointj merged commit 2815c3a into NixOS:master Jun 16, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants