Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-disk-image: fix build for systems that use boot.loader.grub.devices #319238

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 12, 2024

config.boot.loader.grub.device is just an alias that gets assigned to config.boot.loader.grub.devices. If config.boot.loader.grub.device is set to null, it will fail with the following error as described in nix-community/nixos-generators#339

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@Mic92
Copy link
Member Author

Mic92 commented Jun 12, 2024

$ nixos-generate -f do -I nixpkgs=https://github.com/Mic92/nixpkgs/archive/refs/heads/digital-ocean.tar.gz

config.boot.loader.grub.device is just an alias that gets assigned to config.boot.loader.grub.devices.
If config.boot.loader.grub.device is set to null, it will fail with the following error
as described in nix-community/nixos-generators#339
@Mic92
Copy link
Member Author

Mic92 commented Jun 14, 2024

I started to do a regression test over all the images here: nix-community/nixos-generators#341 and here nix-community/nixos-images#239

Mic92 added a commit to nix-community/nixos-generators that referenced this pull request Jun 14, 2024
Mic92 added a commit to nix-community/nixos-generators that referenced this pull request Jun 14, 2024
@Mic92
Copy link
Member Author

Mic92 commented Jun 14, 2024

  • Builds for all images in nixos-generators and nixos-images.

@Mic92 Mic92 merged commit 2654628 into NixOS:master Jun 23, 2024
27 checks passed
@Mic92 Mic92 deleted the digital-ocean branch June 23, 2024 11:28
@Mic92 Mic92 added the backport release-24.05 Backport PR automatically label Jun 24, 2024
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant