Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkd3d-proton: update and adopt #319877

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Splitted from #294280

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member Author

@SuperSandro2000 it is really needed to devendor this?
I did not end it completely yet, but there are three submodules and one of them has another three extra submodules.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4095

@AndersonTorres
Copy link
Member Author

@SuperSamus here is vkd3d-proton, with updates!

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you cleanup the history a bit and combine the refactors? When reviewing commit by commit, I got confused and only saw latter that some comments where already fixed.

pkgs/by-name/vk/vkd3d-proton/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vk/vkd3d-proton/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vk/vkd3d-proton/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vk/vkd3d-proton/sources.nix Outdated Show resolved Hide resolved
@AndersonTorres AndersonTorres changed the title Vkd3d-proton: update vkd3d-proton: update and adopt Jun 19, 2024
@AndersonTorres AndersonTorres force-pushed the vkd3d-proton branch 3 times, most recently from 706b7a1 to bb927f2 Compare June 24, 2024 03:56
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/by-name/vk/vkd3d-proton/package.nix Outdated Show resolved Hide resolved
- detach sources acquisition to `sources.nix`

  Because it is a bit complex:
  - fetchSubmodules
    - maybe they should be manually fetched?
  - the build scripts call Git commands

  Also, pass them as input and as passthru.

- split outputs
- strictDeps
- no nested with
- change maintainer to AndersonTorres
@Sigmanificient Sigmanificient added the 0.kind: package adoption Requests for adopting packages that have no maintainers label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants