-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vkd3d-proton: update and adopt #319877
base: master
Are you sure you want to change the base?
vkd3d-proton: update and adopt #319877
Conversation
@SuperSandro2000 it is really needed to devendor this? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4095 |
@SuperSamus here is vkd3d-proton, with updates! |
ce99d94
to
71e54d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you cleanup the history a bit and combine the refactors? When reviewing commit by commit, I got confused and only saw latter that some comments where already fixed.
71e54d9
to
2e5e022
Compare
706b7a1
to
bb927f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
bd27936
to
c75dd92
Compare
- detach sources acquisition to `sources.nix` Because it is a bit complex: - fetchSubmodules - maybe they should be manually fetched? - the build scripts call Git commands Also, pass them as input and as passthru. - split outputs - strictDeps - no nested with - change maintainer to AndersonTorres
c75dd92
to
cad0990
Compare
Description of changes
Splitted from #294280
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.