Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatsu: init at 0.2.0 #320173

Merged
merged 2 commits into from
Jun 16, 2024
Merged

hatsu: init at 0.2.0 #320173

merged 2 commits into from
Jun 16, 2024

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented Jun 16, 2024

Description of changes

add hatsu package.

closed #320169

Project description

Self-hosted & Fully-automated ActivityPub Bridge for Static Sites.

Metadata

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution; some feedback below:

pkgs/by-name/ha/hatsu/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ha/hatsu/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ha/hatsu/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ha/hatsu/package.nix Outdated Show resolved Hide resolved
@kwaa
Copy link
Member Author

kwaa commented Jun 16, 2024

Thanks for the contribution; some feedback below:

Thanks for the review, I've made the suggested changes.

Copy link
Member

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

builds fine, but fails at runtime; not sure how this is meant to be tested/used

2024-06-16T04:41:12.917607Z  INFO hatsu: Hatsu v0.2.0 "celluloid"
2024-06-16T04:41:12.917618Z  INFO hatsu: loading environment variables
Error: AppError { error: "environment variable not found", error_id: 2373cf99-cfee-4c07-af68-bee029a69843, error_details: None, status: 500, context: SpanTrace [] }

@kwaa
Copy link
Member Author

kwaa commented Jun 16, 2024

builds fine, but fails at runtime; not sure how this is meant to be tested/used

The environments HATSU_PRIMARY_ACCOUNT and HATSU_DOMAIN need to be set.
This is a simple example:

HATSU_PRIMARY_ACCOUNT="kwaa.dev" HATSU_DOMAIN="hatsu.local" nix run .#hatsu

The service will run at http://localhost:3939. (OpenAPI: http://localhost:3939/swagger-ui)
Other environments: https://hatsu.cli.rs/admins/environments.html

@onny
Copy link
Contributor

onny commented Jun 16, 2024

Result of nixpkgs-review pr 320173 run on x86_64-linux 1

1 package built:
  • hatsu

@onny onny merged commit c204732 into NixOS:master Jun 16, 2024
24 of 25 checks passed
@onny
Copy link
Contributor

onny commented Jun 16, 2024

Thank you!

@kwaa kwaa deleted the hatsu branch June 17, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Hatsu
4 participants