Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/17.09] system-config-printer: fix python path #32023

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

andir
Copy link
Member

@andir andir commented Nov 25, 2017

propagated dependencies were not added to PYTHONPATH

(cherry picked from commit b69cbfa269879d9bcf919c0489728cbc9d4c0f3e)

Motivation for this change

Installed a vanilla gnome3 with printing enabled. Figured out the printer configuration dialog wasn't working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

propagated dependencies were not added to PYTHONPATH

(cherry picked from commit b69cbfa269879d9bcf919c0489728cbc9d4c0f3e)
@Mic92 Mic92 merged commit 673c305 into NixOS:release-17.09 Nov 25, 2017
@andir andir deleted the 17.09-fix-gnome3-printing branch November 25, 2017 14:36
@andir
Copy link
Member Author

andir commented Nov 25, 2017

Interesting I'm curious how @GrahamcOfBorg (@grahamc) could eval the expression then... pysmbc should have been removed. I thought I did that while re-basing it - since I actually tested it on a spare notebook. Feel free to push a commit removing that package reference.

(cc @bjornfor)

@bjornfor
Copy link
Contributor

Reverted: 1349aed.

@andir
Copy link
Member Author

andir commented Nov 25, 2017

Thanks! But removing pysmbc would have been enough.

@bjornfor
Copy link
Contributor

Oh, didn't catch that.

@grahamc
Copy link
Member

grahamc commented Nov 25, 2017

Interesting! Looking in my log I see:

INFO:ofborg::outpathdiff: Failed to find After list

indicating it did fail to eval ... now why didn't it note that ... 🤔

@grahamc
Copy link
Member

grahamc commented Nov 25, 2017

Fixed, thank you for the ping: grahamc/ofborg@7a3b7d0...7ee4a0d

@andir
Copy link
Member Author

andir commented Nov 25, 2017

@bjornfor can you commit a revert to the revert that removes the pysmbc as well or should I open another PR?

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Nov 25, 2017 via email

@bjornfor
Copy link
Contributor

I did the re-revert (minus pysmbc) here: b03e6f9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants