-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable/17.09] system-config-printer: fix python path #32023
Conversation
propagated dependencies were not added to PYTHONPATH (cherry picked from commit b69cbfa269879d9bcf919c0489728cbc9d4c0f3e)
Interesting I'm curious how @GrahamcOfBorg (@grahamc) could eval the expression then... (cc @bjornfor) |
Reverted: 1349aed. |
Thanks! But removing |
Oh, didn't catch that. |
Interesting! Looking in my log I see:
indicating it did fail to eval ... now why didn't it note that ... 🤔 |
Fixed, thank you for the ping: grahamc/ofborg@7a3b7d0...7ee4a0d |
@bjornfor can you commit a revert to the revert that removes the pysmbc as well or should I open another PR? |
If you wouldn’t mind could you:
1. open a pr with a straight revert of the revert to ensure my fix reveals
the problem
2. Open a pr with a revert of the revert modified to remove pysmbc?
…On Sat, Nov 25, 2017 at 5:49 PM Andreas Rammhold ***@***.***> wrote:
@bjornfor <https://github.com/bjornfor> can you commit a revert to the
revert that removes the pysmbc as well or should I open another PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32023 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYRM6sAK220jFWIe6DFnnk1NF9umFDOdks5s6JlvgaJpZM4QqZi0>
.
|
I did the re-revert (minus pysmbc) here: b03e6f9. |
propagated dependencies were not added to PYTHONPATH
(cherry picked from commit b69cbfa269879d9bcf919c0489728cbc9d4c0f3e)
Motivation for this change
Installed a vanilla gnome3 with printing enabled. Figured out the printer configuration dialog wasn't working.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)