Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textidote: init at 0.8.3 #321054

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

magneticflux-
Copy link
Contributor

@magneticflux- magneticflux- commented Jun 19, 2024

Description of changes

Closes #269754

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@magneticflux-
Copy link
Contributor Author

@Sntx626 could you test to make sure your use-case works? I've tested that it works for the TeXiFy IDEA plugin on my own documents.

@Sntx626
Copy link

Sntx626 commented Jun 19, 2024

Build & used on:

  • aarch64-linux
  • x86_64-linux

@Sntx626 could you test to make sure your use-case works? I've tested that it works for the TeXiFy IDEA plugin on my own documents.

Yes, it works for my use-case! At the moment I'm running a watcher script that re-runs textidote whenever I update my project.

@magneticflux-
Copy link
Contributor Author

To anyone more experienced at this: is this the best way to go about tracking the dozen or so dependencies? Unfortunately this Ant build isn't much better than a Makefile so there's no lockfile to track dependencies like with NPM, Cargo, Maven, or Gradle. I've never messed around with "manually" creating a Fixed Output Derivation before, but it seems kinda like how the Maven wrapper is built (except in this case our dependencies are downloaded manually and mixed in with the source code 🙄).

@magneticflux-
Copy link
Contributor Author

Thanks for the help! I copied an old Java package and built off of that, so some old-style code crept in without me knowing the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: TeXtidote
3 participants