Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel-launcher: init at 7.7.0 #321115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pluiedev
Copy link
Contributor

Description of changes

Fixes #320311. I don't have any ROMs to test this with, so any feedback from testing by actual users is very welcome!

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@matteo-pacini
Copy link
Contributor

Result of nixpkgs-review pr 321115 run on aarch64-darwin 1

1 package failed to build:
  • parallel-launcher

Log

In file included from /nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__memory/shared_ptr.h:23:
/nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__memory/allocator.h:93:5: error: static assertion failed due to requirement '!is_volatile::value': std::allocator does not support volatile types
static_assert(!is_volatile<_Tp>::value, "std::allocator does not support volatile types");
^ ~~~~~~~~~~~~~~~~~~~~~~~~
/nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__memory/shared_ptr.h:501:80: note: in instantiation of template class 'std::allocator' requested here
_cntrl = new _CntrlBlk(__p, __shared_ptr_default_delete<_Tp, _Yp>(), _AllocT());
^
./src/core/async.hpp:15:13: note: in instantiation of function template specialization 'std::shared_ptr::shared_ptr<volatile bool, void>' requested here
m_value = std::shared_ptr( new volatile bool( false ) );
^
1 error generated.
make: *** [Makefile:2131: build/release/obj/src/main.o] Error 1
In file included from src/core/migration.cpp:13:
In file included from ./src/polyfill/file.hpp:4:
In file included from /nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/fstream:199:
In file included from /nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/filesystem:435:
In file included from /nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__filesystem/directory_entry.h:20:
In file included from /nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__filesystem/filesystem_error.h:15:
/nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__filesystem/path.h:856:39: error: class member cannot be redeclared
_LIBCPP_HIDE_FROM_ABI _VSTD::string u8string() const { return _pn; }
^
./src/core/filesystem.hpp:6:18: note: expanded from macro 'u8string'
#define u8string string
^
/nix/store/mhmq1fci2kw6jp6qjv9hnryx147d8zpr-libcxx-16.0.6-dev/include/c++/v1/__filesystem/path.h:852:39: note: previous definition is here
_LIBCPP_HIDE_FROM_ABI _VSTD::string string() const { return _pn; }
^
In file included from src/core/migration.cpp:15:
In file included from ./src/db/sqlite.hpp:9:
In file included from ./src/core/rom.hpp:8:
In file included from ./src/core/settings.hpp:7:
./src/core/json.hpp:57:14: warning: implicit conversion from 'type' (aka 'long long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
value <= std::numeric_limits::max()
~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./src/core/json.hpp:219:95: note: in instantiation of function template specialization 'JsonInternals::fits<long long, double>' requested here
if( maybeDouble != nullptr && *maybeDouble == std::trunc( *maybeDouble ) && JsonInternals::fits( *maybeDouble ) ) {
^
./src/core/json.hpp:97:10: note: in instantiation of function template specialization 'Json::tryGet' requested here
return tryGet().value_or( defaultValue );
^
src/core/migration.cpp:117:47: note: in instantiation of function template specialization 'Json::getOrDefault' requested here
const int64 lastPlayed = json["last_played"].getOrDefault( 0 );
^
1 warning and 1 error generated.
make: *** [Makefile:2346: build/release/obj/src/core/migration.o] Error 1

@pluiedev
Copy link
Contributor Author

pluiedev commented Jun 19, 2024

Result of nixpkgs-review pr 321115 run on aarch64-darwin 1
1 package failed to build:

Log

Not even sure if upstream even supports aarch64-darwin — they straight up tell you to use the x86 version and run it through Rosetta 2 😅

@matteo-pacini
Copy link
Contributor

@pluiedev Sounds fair! Could you please remove aarch64-darwin from the platforms then? 🙏🏻

@pluiedev
Copy link
Contributor Author

pluiedev commented Jun 19, 2024

Upon further examination, the PKGBUILD specifies that it's only supposed to build for x86_64. Going to restrict it to x86_64-linux, x86_64-darwin and x86_64-windows for now

@matteo-pacini
Copy link
Contributor

@pluiedev sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: parallel-launcher
2 participants