-
-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
irrlicht: 1.8.4 -> 1.8.5 #321139
base: master
Are you sure you want to change the base?
irrlicht: 1.8.4 -> 1.8.5 #321139
Conversation
Result of 2 packages built:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1775 |
https://hydra.nixos.org/build/265430711 |
@@ -39,5 +39,6 @@ stdenv.mkDerivation rec { | |||
license = lib.licenses.zlib; | |||
description = "Open source high performance realtime 3D engine written in C++"; | |||
platforms = lib.platforms.darwin; | |||
broken = lib.platforms.darwin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
broken = lib.platforms.darwin; | |
broken = stdenv.isDarwin; |
or
broken = lib.platforms.darwin; | |
badPlatforms = lib.platforms.darwin; |
Description of changes
Fixes #321031
Changelog: https://irrlicht.sourceforge.io/forum/viewtopic.php?f=2&t=52775
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.