Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

loopwm: init at 1.0.0 #321219

Merged
merged 1 commit into from
Jun 27, 2024
Merged

loopwm: init at 1.0.0 #321219

merged 1 commit into from
Jun 27, 2024

Conversation

matteo-pacini
Copy link
Contributor

Description of changes

Added loopwm (Loop window manager) for *-darwin, to distinguish it from the package loop.

Description from the repo:

Loop is a macOS app that simplifies window management for you! You can effortlessly choose your window direction using a radial menu triggered by a simple key press, and customize it according to your preferences with personalized colors and settings. You can easily move, resize, and arrange your windows with just a few clicks, saving you valuable time and energy.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4132

@afh
Copy link
Contributor

afh commented Jun 23, 2024

Result of nixpkgs-review pr 321219 run on aarch64-darwin 1

1 package built:
  • loopwm

Copy link
Contributor

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installed application fails to launch with

image

What could be the cause of that? This is how I built the package from this PR:

/usr/bin/env NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 \
nix build --impure github:NixOS/nixpkgs/pull/321219/merge#loopwm
open result/Applications/Loop.app

pkgs/by-name/lo/loopwm/package.nix Outdated Show resolved Hide resolved
@matteo-pacini
Copy link
Contributor Author

matteo-pacini commented Jun 23, 2024

@afh I think it's SIP flagging the app, as Nix sets all file dates to 1 second after Epoch.

Happens to me with all pre-compiled apps, and the only way to fix it is to navigate to Settings -> Privacy and Security, scroll down the list, find the app rejection, and tap on "Open Anyway". You will get again a warning prompt, but this time you should have an option to actually open the app.

EDIT: This steps I do work on aarch64-darwin, macOS Sonoma.

@matteo-pacini
Copy link
Contributor Author

@afh Thanks for the feedback also, an update has been pushed.

Ready for re-review 馃檹馃徎

Copy link
Contributor

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the review suggestions and providing helpful context on the error I observed. 馃憤

Find below a comemnt about a minor nit that might be worthwhile to address in case you wanted to go above and beyond with this PR.

pkgs/by-name/lo/loopwm/package.nix Outdated Show resolved Hide resolved
@matteo-pacini
Copy link
Contributor Author

@afh I'm all-in for good-practices, thanks for the feedback, ready for re-review 馃檹馃徎

Copy link
Contributor

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, @matteo-pacini! 馃憤

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1772

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1779

@SuperSandro2000 SuperSandro2000 merged commit 533a48e into NixOS:master Jun 27, 2024
25 checks passed
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants