Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-sso-cli: 1.15.1 -> 1.16.1 #321816

Merged
merged 1 commit into from
Jun 28, 2024
Merged

aws-sso-cli: 1.15.1 -> 1.16.1 #321816

merged 1 commit into from
Jun 28, 2024

Conversation

devusb
Copy link
Contributor

@devusb devusb commented Jun 22, 2024

Description of changes

synfinatic/aws-sso-cli@v1.15.1...v1.16.1

  • add getent to nativeCheckInputs needed for new upstream test
  • skip TestDetectShellBash on Darwin (requires dscl)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@devusb
Copy link
Contributor Author

devusb commented Jun 22, 2024

Result of nixpkgs-review pr 321816 run on aarch64-darwin 1

1 package built:
  • aws-sso-cli

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4150

@Artturin Artturin merged commit b0fdd6f into NixOS:master Jun 28, 2024
24 checks passed
@devusb devusb deleted the aws-sso-cli branch July 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants