Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai-whisper-cpp: 1.5.4 -> 1.6.2 #321941

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

davidkna
Copy link
Contributor

@davidkna davidkna commented Jun 23, 2024

Description of changes

Changelogs

  • Bumped sources from 1.5.4 to 1.6.2
  • Updated the download-models patch to handle changes to upstream script
  • For darwin, replaced wrapProgram that sets GGML_METAL_PATH_RESOURCES with WHISPER_METAL_EMBED_LIBRARY build option.

Note: openai-whisper-cpp has ffmpeg support now, but that would require switching to CMake.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Tested model download script and both the Metal and CoreML backends for the main whisper-cpp binary.


Add a 👍 reaction to pull requests you find important.

@hughobrien
Copy link
Contributor

hughobrien commented Jun 23, 2024

Result of nixpkgs-review pr 321941 run on x86_64-linux 1

1 package built:
  • openai-whisper-cpp

Tested on some audio files also and all good.

@h7x4 h7x4 merged commit 6fb82de into NixOS:master Jun 24, 2024
40 checks passed
@davidkna davidkna deleted the openai-whisper-cpp-1.6.2 branch June 24, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants