Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sfwbar: 1.0_beta14 -> 1.0_beta15 #322134

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

luftmensch-luftmensch
Copy link
Contributor

Description of changes

Release notes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1773

@NotAShelf
Copy link
Member

Result of nixpkgs-review pr 322134 run on x86_64-linux 1

1 package built:
  • sfwbar

@NotAShelf
Copy link
Member

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@NotAShelf merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@NotAShelf
Copy link
Member

Oh well.

I've tested build and the functionality, all seems good. This can be merged.

@wegank wegank merged commit 7516674 into NixOS:master Jun 25, 2024
30 checks passed
@luftmensch-luftmensch luftmensch-luftmensch deleted the sfwbar_1.0_beta15 branch June 25, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants