polkit: Apply unreleased patch to fix pkexec without a graphical agent

[Artturin]

Merged upstream PR https://www.github.com/polkit-org/polkit/pull/423

Fixes #18012

Redo of #144797 now that the upstream PR is merged

Description of changes

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[jtojnar]

Looks okay. Thanks.

[Atemu]

Just for context, in https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/59#note_2100970 you said that the previous iteration of that PR couldn't be reviewed and is security-critical; what changed?

[Artturin]

Just for context, in https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/59#note_2100970 you said that the previous iteration of that PR couldn't be reviewed and is security-critical; what changed?

Upstream has merged the PR (they switched to github, pr description has the link)

[github-actions]

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-322207-to-release-24.05 origin/release-24.05
cd .worktree/backport-322207-to-release-24.05
git switch --create backport-322207-to-release-24.05
git cherry-pick -x 26b7b2fe4d95856c1d44751f0035292b5d98362c

[Artturin]

#322981

[Atemu]

I still don't understand how the choice of forge would influence the decision to merge changes that cannot easily be reviewed?

[Artturin]

I still don't understand how the choice of forge would influence the decision to merge changes that cannot easily be reviewed?

The quote I had in https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/59#note_2100970 was from @jtojnar #144797 (comment) (Who is not an upstream developer)

Now https://gitlab.freedesktop.org/polkit/polkit/-/merge_requests/59 has been recreated by an upstream developer polkit-org/polkit#423 and reviewed&merged by the upstream developer