Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centerpiece: fix for x11 #322553

Merged
merged 1 commit into from
Jul 2, 2024
Merged

centerpiece: fix for x11 #322553

merged 1 commit into from
Jul 2, 2024

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jun 26, 2024

Description of changes

without this I get errors like:

❯ ./result/bin/centerpiece
thread 'main' panicked at /build/centerpiece-1.1.0-vendor.tar.gz/winit/src/platform_impl/linux/mod.rs:757:9:
Failed to initialize any backend! Wayland status: NoCompositorListening X11 status: LibraryOpenError(OpenError { kind: Library, detail: "opening library failed (libX11.so.6: cannot open shared object file: No such file or directory); opening library failed (libX11.so: cannot open shared object file: No such file or directory)" })
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

According to the project's README:

A blazing fast, extendable launcher for wayland

but it seems to work with x11, so not sure if we should support it or not.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 322553 run on x86_64-linux 1

1 package built:
  • centerpiece

@friedow
Copy link
Member

friedow commented Jun 27, 2024

I can't really test this because I don't have an X11 environment. @JohnRTitor can you test running it with these changes on X11?

@a-kenji
Copy link
Contributor

a-kenji commented Jul 2, 2024

Result of nixpkgs-review pr 322553 run on x86_64-linux 1

1 package built:
  • centerpiece

Tested outputs seems to work, thank you @bbigras!

@JohnRTitor
Copy link
Contributor

I can't really test this because I don't have an X11 environment. @JohnRTitor can you test running it with these changes on X11?

Unfortunately I do not use an X11 session.

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 322553 run on x86_64-linux 1

1 package built:
  • centerpiece

@JohnRTitor JohnRTitor merged commit 73f6fe4 into NixOS:master Jul 2, 2024
24 checks passed
@bbigras
Copy link
Contributor Author

bbigras commented Jul 2, 2024

Thanks everyone.

@bbigras bbigras deleted the centerpiece branch July 2, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants