Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vesktop: 1.5.2 -> 1.5.3 #325104

Merged
merged 1 commit into from
Jul 8, 2024
Merged

vesktop: 1.5.2 -> 1.5.3 #325104

merged 1 commit into from
Jul 8, 2024

Conversation

JManch
Copy link
Contributor

@JManch JManch commented Jul 6, 2024

Description of changes

https://github.com/Vencord/Vesktop/releases/tag/v1.5.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm. thanks!

pkgs/top-level/all-packages.nix Show resolved Hide resolved
@NyCodeGHG
Copy link
Member

Result of nixpkgs-review pr 325104 run on x86_64-linux 1

1 package built:
  • vesktop

@yayayayaka yayayayaka merged commit bedbc6e into NixOS:master Jul 8, 2024
28 checks passed
@JManch JManch deleted the vesktop branch July 8, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants