Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scid-vs-pc: init at version 4.18.1 #33792

Merged
merged 3 commits into from Jan 14, 2018
Merged

scid-vs-pc: init at version 4.18.1 #33792

merged 3 commits into from Jan 14, 2018

Conversation

paraseba
Copy link
Contributor

Motivation for this change

scid vs. PC is a chess program forked from scid and more maintained than the original. scid was packaged already

cc: @aszlig (packager of scid)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

scid vs pc is a chess database and playing program, a more maintained fork of
scid. scid was already packaged so this change adds a very similar expression.

Currently scid and scid-vs-pc collide since they install the same binaries.
@paraseba
Copy link
Contributor Author

To make reviewing easier, compare the expression for this package to the one for scid in which it is based: https://github.com/NixOS/nixpkgs/blob/5c73ee1a9375d225a66a4fd469fc82e59a2d7414/pkgs/games/scid/default.nix

@grahamc
Copy link
Member

grahamc commented Jan 14, 2018

@GrahamcOfBorg build scid-vs-pc

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

    Location of "tk.h": not found
    Location of Tcl 8.6 library: /nix/store/zr4n0fdb3nsdp80vff9mihks22w1g8jm-tcl-8.6.6/lib
    Location of Tk 8.6 library: /nix/store/bwlx46zncj2c6bv2sn75ai0wgzc89d93-tk-8.6.6/lib
    Location of X11 library: /nix/store/093lzjvm2r27rprpqxvyrgqvfp1k0dlf-libX11-1.6.5/lib/
    Checking if your system already has zlib installed: no.

Error: compiler g++ does not support C++0x (C++11).

builder for '/nix/store/jy1yk462rxmsarblzvqqgyyilsdby2wr-scid-vs-pc-4.18.1.drv' failed with exit code 1
error: build of '/nix/store/jy1yk462rxmsarblzvqqgyyilsdby2wr-scid-vs-pc-4.18.1.drv' failed

@paraseba
Copy link
Contributor Author

@grahamc does that error mean I need to set platform to linux?

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/scidt
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/phalanx
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/tcscid
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/fruit
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/scidlet
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/pgnscid
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin 
checking for references to /tmp/nix-build-scid-vs-pc-4.18.1.drv-0 in /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1...
/nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/scidt
shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/scidlet
shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/scmerge
shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/tcscid
shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/tkscid
shrinking /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin/pgnscid
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1/bin
checking for references to /build in /nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1...
/nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1

@grahamc
Copy link
Member

grahamc commented Jan 14, 2018

You could if you'd like, but I wouldn't worry too much about it. Would you like to?

@paraseba
Copy link
Contributor Author

@grahamc let me give setting platform a try, and learn something while I do it. Thank you

Darwin spits the following error:

  Location of "tk.h": not found
    Location of Tcl 8.6 library: /nix/store/zr4n0fdb3nsdp80vff9mihks22w1g8jm-tcl-8.6.6/lib
    Location of Tk 8.6 library: /nix/store/bwlx46zncj2c6bv2sn75ai0wgzc89d93-tk-8.6.6/lib
    Location of X11 library: /nix/store/093lzjvm2r27rprpqxvyrgqvfp1k0dlf-libX11-1.6.5/lib/
    Checking if your system already has zlib installed: no.

Error: compiler g++ does not support C++0x (C++11).
@paraseba
Copy link
Contributor Author

@GrahamcOfBorg build scid-vs-pc

@grahamc
Copy link
Member

grahamc commented Jan 14, 2018

@GrahamcOfBorg build scid-vs-pc

(only certain people can call it)

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘scid-vs-pc-4.18.1’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/games/scid-vs-pc/default.nix:64 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/a37xd833hkdbck0dxi6kv7zyjn6q0yrn-scid-vs-pc-4.18.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/tkscid
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/tcscid
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/scidlet
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/phalanx
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/fruit
shrinking /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin/scidt
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1/bin 
checking for references to /tmp/nix-build-scid-vs-pc-4.18.1.drv-0 in /nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1...
/nix/store/m1zl9ykyc4fx8f8yvwv5j5asyf2cis10-scid-vs-pc-4.18.1

@grahamc grahamc merged commit 34b4d41 into NixOS:master Jan 14, 2018
@paraseba
Copy link
Contributor Author

Thanks for merging

@grahamc
Copy link
Member

grahamc commented Jan 14, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants