Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinyxml-2: 4.0.1 -> 6.0.0 #33950

Merged
merged 1 commit into from Feb 14, 2018
Merged

tinyxml-2: 4.0.1 -> 6.0.0 #33950

merged 1 commit into from Feb 14, 2018

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Jan 16, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this builds. Also the only (non-broken) package dependent on this library (lgogdownloader) builds as well.

@dtzWill
Copy link
Member

dtzWill commented Feb 5, 2018

@GrahamcOfBorg build tinyxml2 lgogdownloader

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘lgogdownloader-3.2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/games/lgogdownloader/default.nix:21 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2
shrinking /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2/bin/lgogdownloader
gzipping man pages under /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2/bin 
patching script interpreter paths in /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2
checking for references to /tmp/nix-build-lgogdownloader-3.2.drv-0 in /nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2...
/nix/store/d4xfwapkln8z5d4gpwwajrh4hvrq4p00-tinyxml-2.6.2
/nix/store/p4gxi0cycfmksyd2fic4a1nbd073idkj-lgogdownloader-3.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2
shrinking /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2/bin/lgogdownloader
gzipping man pages under /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2/bin
patching script interpreter paths in /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2
checking for references to /build in /nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2...
/nix/store/fii6q20536crggiqrdz919893bdnis2p-tinyxml-2.6.2
/nix/store/bbipr3mi0zlqnhpnxx6jdy7mwc0xsfjx-lgogdownloader-3.2

@acowley
Copy link
Contributor Author

acowley commented Feb 14, 2018

Bump and ping @dezgeg and @joachifm as they are the two previous contributors to this package.

@joachifm joachifm merged commit 68bf89e into NixOS:master Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants