[WIP] anbox: init at 2018-01-06 #33970

lukeadams · 2018-01-17T06:13:23Z

Motivation for this change

pr for tracking

Anbox allows execution of Android apps within a lxc namespace on the host kernel.
Requires binder and ashmem kmods (included in src), in addition to application of kernel patches.

Probably need to add a NixOS module for this eventually.

Needed to add dbus-cpp (not the same as dbus-cplusplus) and a few other libraries.

~~currently library commits are after Anbox, need to rebase~~
Rebased as much as possible (now anbox init is after deps). Still need to reorder to be in the following order for bisectability:

libproperties
libprocess
dbus-cpp

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-01-17T16:48:15Z

We also did some work to get it working here in the past:

https://github.com/volth/nixpkgs/commits/anbox

However it was never finished - maybe you can borrow some code.

lukeadams · 2018-01-17T18:26:59Z

That's awesome! Thanks for the link.
I neglected to mention that this does build and run, I just need to see how pkg-provided kernel modules are usually done, and it looks like you guys already got it working – I should be able to cherry pick the NixOS module commits for that! Looks like you guys finished the udev rules, etc. Also looks like you were able to figure out gmock which is nice; I just disabled testing to get it to build.

I like how the linked commits include process-cpp and friends in the anbox cfg for simplicity. Main issue I had to hunt down was newer boost versions (>=1.60) causing issues due to the use of deprecated functions – Anbox only used deprecated functions in one location (might submit upstream pr) but process-cpp and libproperties haven't been updated I suppose due to Ubuntu using an older boost dist-wide...

Also had no idea about fetchbzr

Would eventually like to test this on ARM on my rpi2/nitrogen6x as that's my use case.

allows auto-selection by images.${stdenv.system}

Mic92 · 2018-01-17T22:01:19Z

In the module you will need also some networking for LXC, if I remember correctly.

lukeadams · 2018-01-26T00:26:47Z

Since volth's branch is relatively complete I'm going to overlay my changes on top of those commits. I've rebased onto master and resolved merge conflicts in this branch, which will eventually become the one in this pr

Mic92 · 2018-02-28T14:23:58Z

pkgs/development/libraries/dbus-cpp/default.nix

+    description = "C++ API for D-BUS";
+    license = licenses.gpl2Plus;
+    platforms = platforms.linux;
+    maintainers = [ maintainers.goibhniu ];


is @goibhniu ok with that?

maintainer left in due to copy-pasting ;)
most of my commits will be replaced by those in Volth's branch when I get a chance to finish that

Mic92 · 2018-02-28T14:24:12Z

pkgs/development/libraries/libprocess-cpp/default.nix

+    description = "C++ API for D-BUS";
+    license = licenses.gpl2Plus;
+    platforms = platforms.linux;
+    maintainers = [ maintainers.goibhniu ];


Mic92 · 2018-02-28T14:25:04Z

pkgs/development/libraries/dbus-cpp/default.nix

+    truncate -s 0 tests/CMakeLists.txt
+  '';
+
+  meta = with stdenv.lib; {


meta is incorrect

Mic92 · 2018-02-28T14:25:15Z

pkgs/development/libraries/libproperties-cpp/default.nix

+    description = "C++ API for D-BUS";
+    license = licenses.gpl2Plus;
+    platforms = platforms.linux;
+    maintainers = [ maintainers.goibhniu ];


soredake · 2018-04-06T09:59:00Z

Any progress?

lukeadams · 2018-04-06T18:09:36Z

Not recently. I plan to finish this PR sometime early to mid May once my classes finish.

sauyon · 2018-05-26T15:05:26Z

ETA?

Chiiruno · 2018-05-27T13:47:57Z

I'd also like to see this finished, are you still working on it?

lukeadams · 2018-05-30T05:36:27Z

I personally no longer need it and stopped working on it as a result. Sorry about that...
I'd love to finish it to play around with but its been extremely busy...

add self to maintainers

3bc2bc0

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Jan 17, 2018

Luke Adams added 8 commits January 17, 2018 12:40

dbus-cpp: init at 5.0.0

e7f620c

libprocess-cpp: init at 3.0.1

52d64fd

libproperties-cpp: init at 0.0.1

6b04f85

anbox: init at 2018-01-06

f38cff5

anbox: build kmod-binder

af9156f

anbox: build kmod-ashmem

043884c

anbox: reorder build inputs

361b23a

anbox: image platforms now reflect stdenv.system

cf1eb55

allows auto-selection by images.${stdenv.system}

lukeadams force-pushed the anbox branch from dcc9ea2 to cf1eb55 Compare January 17, 2018 18:44

Luke Adams added 5 commits January 19, 2018 14:57

gmock notice

a9e14fc

parallel

983da18

comment

ee86ace

anbox: finalize android-image urls/shas

fd828d2

progress

76a3b49

Mic92 reviewed Feb 28, 2018

View reviewed changes

pkgs/development/libraries/dbus-cpp/default.nix

truncate -s 0 tests/CMakeLists.txt

'';

meta = with stdenv.lib; {

Copy link

Member

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta is incorrect

Mic92 reviewed Feb 28, 2018

View reviewed changes

matthewbauer added the 2.status: work-in-progress label Mar 22, 2018

lukeadams closed this May 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] anbox: init at 2018-01-06 #33970

[WIP] anbox: init at 2018-01-06 #33970

lukeadams commented Jan 17, 2018 •

edited

Mic92 commented Jan 17, 2018

lukeadams commented Jan 17, 2018 •

edited

Mic92 commented Jan 17, 2018 •

edited

lukeadams commented Jan 26, 2018 •

edited

Mic92 Feb 28, 2018

lukeadams Mar 1, 2018

Mic92 Feb 28, 2018

Mic92 Feb 28, 2018

Mic92 Feb 28, 2018

soredake commented Apr 6, 2018

lukeadams commented Apr 6, 2018

sauyon commented May 26, 2018

Chiiruno commented May 27, 2018

lukeadams commented May 30, 2018 •

edited

[WIP] anbox: init at 2018-01-06 #33970

[WIP] anbox: init at 2018-01-06 #33970

Conversation

lukeadams commented Jan 17, 2018 • edited

Motivation for this change

Things done

Mic92 commented Jan 17, 2018

lukeadams commented Jan 17, 2018 • edited

Mic92 commented Jan 17, 2018 • edited

lukeadams commented Jan 26, 2018 • edited

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

lukeadams Mar 1, 2018

Choose a reason for hiding this comment

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

soredake commented Apr 6, 2018

lukeadams commented Apr 6, 2018

sauyon commented May 26, 2018

Chiiruno commented May 27, 2018

lukeadams commented May 30, 2018 • edited

lukeadams commented Jan 17, 2018 •

edited

lukeadams commented Jan 17, 2018 •

edited

Mic92 commented Jan 17, 2018 •

edited

lukeadams commented Jan 26, 2018 •

edited

lukeadams commented May 30, 2018 •

edited