Update and introduce Godot and godot_headers #34971

Twey · 2018-02-14T17:45:29Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

joachifm · 2018-02-16T21:23:30Z

pkgs/development/libraries/godot_headers/default.nix

+{ stdenv, fetchFromGitHub }:
+stdenv.mkDerivation rec {
+  name = "godot_headers";
+  version = "51bca3bf5d917341f3e15076c5a9191f8a5118ae";


Please provide a valid version string; see e.g. parseDrvName. It's common to use the rev date for unreleased versions.

Twey · 2018-02-20T12:27:34Z

I'm not sure why pkg-config requires libpthreadstubs here on non-NixOS builds but not NixOS builds, but this seems to be the case.

EDIT: figured out; fixed.

Twey · 2018-02-23T15:38:28Z

Bump! I build this a lot — would be nice to have it cached.

joachifm · 2018-02-23T19:21:00Z

@GrahamcOfBorg build godot godot_headers

GrahamcOfBorg · 2018-02-23T19:21:19Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘godot-3.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/godot/default.nix:49 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-23T19:25:12Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

scons: *** [thirdparty/thekla_atlas/nvmesh/param/SingleFaceMap.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/nvmesh/param/AtlasPacker.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/nvmesh/weld/VertexWeld.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/nvmesh/param/Util.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/nvmesh/weld/Snap.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/nvmesh/param/AtlasBuilder.x11.tools.64.o] Error 1
scons: *** [thirdparty/thekla_atlas/thekla/thekla_atlas.x11.tools.64.o] Error 1
scons: building terminated because of errors.
builder for '/nix/store/gy7y6bmdhsz6nmfvsjsa6g4kgg7bsbbr-godot-3.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/gy7y6bmdhsz6nmfvsjsa6g4kgg7bsbbr-godot-3.0.drv' failed

GrahamcOfBorg · 2018-02-23T20:10:12Z

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0
shrinking /nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0/bin/godot
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0/bin 
patching script interpreter paths in /nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0
checking for references to /tmp/nix-build-godot-3.0.drv-0 in /nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0...
/nix/store/ggnlh061ikdr36xh5ay1ak7yrnkzix0v-godot-3.0
/nix/store/j0lzvrk0yysazx8kdraxyrf1zrm5gwa1-godot_headers

Twey · 2018-02-23T20:20:19Z

It might be supported on Darwin, but I haven't been able to test.

Twey · 2018-03-01T15:18:04Z

Is something wrong with this PR?

Ekleog · 2018-03-14T00:41:41Z

@Twey Currently the PR can't be merged, most likely due to 1bc1909. You should rebase your changes over this commit, I think :)

Also, ofborg reported a failure on aarch64-linux. Unfortunately full logs have since been deleted (they're deleted 7 days after build completion), so there's no easy way to know what exactly went wrong.

So, as I guess upstream godot has no support of aarch64 (from https://godot.readthedocs.io/en/latest/development/compiling/introduction_to_the_buildsystem.html#bits), so after having checked godot 2.1.4 didn't build on aarch64 either you could just change the meta.platforms value to reflect the “no aarch64” requirement.

Twey · 2018-03-16T21:17:09Z

Thanks a lot! How's this? :)

GrahamcOfBorg · 2018-03-18T22:56:42Z

Success on aarch64-linux (full log)

Attempted: godot_headers

The following builds were skipped because they don't evaluate on aarch64-linux: godot

Partial log (click to expand)

/nix/store/9lamqwqzs005fhxm0pyvl21ri3jaqmg8-godot_headers

Ekleog · 2018-03-18T23:28:52Z

@Twey Guess you'll have to update your patches, likely due to the switch to 3.0.2 ;)

Twey · 2018-03-19T12:17:26Z

I was pretty tired when I pushed that commit…
Should be working now; at least it works locally!

Ekleog · 2018-03-19T12:50:58Z

Thanks!

Just two little things before retriggering a rebuild:

I think you can remove lines 6-7 and replace the + at the beginning of lines 13-14 with spaces, this should make the patch easier to read :) (not really important though)
More importantly, the package currently requires gcc5 for building, which means additional load on ofborg (as indicated by the now-deleted comment of ofborg that pointed to a timeout during the build of gcc5). As AUR's package for godot appears not to force gcc5, do you know whether this package would also build with the default gcc? :)

Twey · 2018-03-19T14:15:52Z

I'm not sure — I was modifying the old one, so I made minimal changes. I'll give it a test.

Twey · 2018-03-19T14:52:12Z

Seems it works!

Ekleog · 2018-03-19T16:41:42Z

@GrahamcOfBorg build godot godot_headers

Twey · 2018-03-20T14:58:57Z

Is this a success output?

Ekleog · 2018-03-20T17:45:04Z

Turns out I didn't have access to ofborg yet, so when NixOS/ofborg#140 is deployed I'll be able to trigger the build, sorry!

Ekleog · 2018-03-20T17:49:10Z

@GrahamcOfBorg build godot godot_headers
(can't beat that speed)

GrahamcOfBorg · 2018-03-20T17:49:40Z

Success on aarch64-linux (full log)

Attempted: godot_headers

The following builds were skipped because they don't evaluate on aarch64-linux: godot

Partial log (click to expand)

configuring
no configure script, doing nothing
building
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9lamqwqzs005fhxm0pyvl21ri3jaqmg8-godot_headers
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/9lamqwqzs005fhxm0pyvl21ri3jaqmg8-godot_headers
checking for references to /build in /nix/store/9lamqwqzs005fhxm0pyvl21ri3jaqmg8-godot_headers...
/nix/store/9lamqwqzs005fhxm0pyvl21ri3jaqmg8-godot_headers

GrahamcOfBorg · 2018-03-20T17:59:11Z

Success on x86_64-linux (full log)

Attempted: godot, godot_headers

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2
shrinking /nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2/bin/godot
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2/bin
patching script interpreter paths in /nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2
checking for references to /tmp/nix-build-godot-3.0.2.drv-0 in /nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2...
/nix/store/190xsjpb4nzk758dl383538c6xw9ydwp-godot-3.0.2
/nix/store/hwfl7jr5pw5l4fq76lk8k2nd7z7pjybd-godot_headers

Ekleog · 2018-03-20T23:23:20Z

I think this is good to merge, modulo x86_64 for which I'm not accredited to trigger builds, due to the lack of sandboxing :)

cc @joachifm, as you had started reviewing it a few weeks ago :)

Twey · 2018-03-26T10:13:52Z

There are three different pull requests for this now… is there some reason they're not being merged?

srhb · 2018-03-27T15:28:20Z

OK, I tested execution of the binary and it looks sane on all accounts to me. I don't know much else about Godot, but I see no glaring issues here, so here goes.

NilsIrl · 2019-08-08T21:25:03Z

@Twey what's the point of pkgs/development/tools/godot/dont_clobber_environment.patch?

Twey force-pushed the master branch from beef7b2 to 8c64b19 Compare February 14, 2018 17:52

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 14, 2018

jtojnar mentioned this pull request Feb 14, 2018

godot: 2.1.4 -> 3.0 #34421

Closed

8 tasks

joachifm reviewed Feb 16, 2018

View reviewed changes

Twey force-pushed the master branch 2 times, most recently from fdfa101 to 87f80e2 Compare February 20, 2018 12:17

Twey force-pushed the master branch from 87f80e2 to 7e3c585 Compare February 21, 2018 12:23

Ekleog mentioned this pull request Mar 14, 2018

Make it explicit when logs have been deleted NixOS/ofborg-viewer#18

Open

Twey added 8 commits March 16, 2018 19:46

godot: 2.1.4 -> 3.0

ef7a25f

godot_headers: init at 51bca3bf5d917341f3e15076c5a9191f8a5118ae

494a4ef

godot_headers: clean up output path

62ab617

godot: clean up output path

ef5fd1c

godot_headers: provide a better version string

2b96b03

godot: stop build process from looking in global directories

7ba969f

godot: restrict build platforms to [ "i686-linux" "x86_64-linux" ]

998f42a

godot: 3.0 -> 3.0.2

5fbbd5e

Twey force-pushed the master branch from 493774c to 5fbbd5e Compare March 16, 2018 19:54

GrahamcOfBorg added the 8.has: clean-up label Mar 16, 2018

grahamc mentioned this pull request Mar 18, 2018

When attributes don't evaluate, we confusingly provide no log NixOS/ofborg#131

Closed

NixOS deleted a comment from GrahamcOfBorg Mar 19, 2018

godot: update patches for 3.0.2

2220b5f

Twey added 2 commits March 19, 2018 14:51

godot: simplify pkg_config_additions.patch

368ed89

godot: don't require gcc5

9508150

This was referenced Mar 25, 2018

godot installation fails #37623

Closed

godot: 2.1.4 -> 3.0.2 #37851

Closed

srhb merged commit 048724c into NixOS:master Mar 27, 2018

xeji mentioned this pull request Mar 27, 2018

18.03 Zero Hydra Failures (generic + x86_64-linux) #36453

Closed

NilsIrl mentioned this pull request Aug 8, 2019

Remove useless dont_clobber_environment.patch for Godot #66349

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update and introduce Godot and godot_headers #34971

Update and introduce Godot and godot_headers #34971

Twey commented Feb 14, 2018 •

edited

joachifm Feb 16, 2018

Twey Feb 20, 2018

Twey commented Feb 20, 2018 •

edited

Twey commented Feb 23, 2018

joachifm commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

Twey commented Feb 23, 2018

Twey commented Mar 1, 2018

Ekleog commented Mar 14, 2018

Twey commented Mar 16, 2018

GrahamcOfBorg commented Mar 18, 2018

Ekleog commented Mar 18, 2018

Twey commented Mar 19, 2018

Ekleog commented Mar 19, 2018

Twey commented Mar 19, 2018

Twey commented Mar 19, 2018

Ekleog commented Mar 19, 2018

Twey commented Mar 20, 2018

Ekleog commented Mar 20, 2018

Ekleog commented Mar 20, 2018

GrahamcOfBorg commented Mar 20, 2018

GrahamcOfBorg commented Mar 20, 2018

Ekleog commented Mar 20, 2018

Twey commented Mar 26, 2018

srhb commented Mar 27, 2018

NilsIrl commented Aug 8, 2019

Update and introduce Godot and godot_headers #34971

Update and introduce Godot and godot_headers #34971

Conversation

Twey commented Feb 14, 2018 • edited

Motivation for this change

Things done

joachifm Feb 16, 2018

Choose a reason for hiding this comment

Twey Feb 20, 2018

Choose a reason for hiding this comment

Twey commented Feb 20, 2018 • edited

Twey commented Feb 23, 2018

joachifm commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

GrahamcOfBorg commented Feb 23, 2018

Twey commented Feb 23, 2018

Twey commented Mar 1, 2018

Ekleog commented Mar 14, 2018

Twey commented Mar 16, 2018

GrahamcOfBorg commented Mar 18, 2018

Ekleog commented Mar 18, 2018

Twey commented Mar 19, 2018

Ekleog commented Mar 19, 2018

Twey commented Mar 19, 2018

Twey commented Mar 19, 2018

Ekleog commented Mar 19, 2018

Twey commented Mar 20, 2018

Ekleog commented Mar 20, 2018

Ekleog commented Mar 20, 2018

GrahamcOfBorg commented Mar 20, 2018

GrahamcOfBorg commented Mar 20, 2018

Ekleog commented Mar 20, 2018

Twey commented Mar 26, 2018

srhb commented Mar 27, 2018

NilsIrl commented Aug 8, 2019

Twey commented Feb 14, 2018 •

edited

Twey commented Feb 20, 2018 •

edited