caprice32 : init at unstable-2018-02-10 #35008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bignaux
changed the title
joachifm
reviewed
Feb 16, 2018
| src = fetchFromGitHub { | ||
| owner = "ColinPitrat"; | ||
| repo = "caprice32"; | ||
| rev = "${rev}"; |
There was a problem hiding this comment.
Nit: you can do inherit rev here, or at least do rev = rev ...
|
@GrahamcOfBorg build caprice32 |
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
joachifm
reviewed
Feb 16, 2018
| postPatch = "substituteInPlace cap32.cfg --replace /usr/local $out"; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "a complete emulation of CPC464, CPC664 and CPC6128"; |
There was a problem hiding this comment.
Please capitalize the description
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ libpng SDL freetype zlib ]; | ||
| makeFlags = [ "GIT_HASH=$(src.rev)" "DESTDIR=$(out)" "prefix=/"]; |
There was a problem hiding this comment.
I wonder if GIT_HASH=$(src.rev) will really work as expected ... I suggest using GIT_HASH=${src.rev} instead.
bignaux
changed the title
bignaux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)