Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of acl and attr from source with unstable Nix #35016

Merged
merged 2 commits into from
Feb 15, 2018

Conversation

abbradar
Copy link
Member

@abbradar abbradar commented Feb 15, 2018

Motivation for this change

Because unstable Nix's /bin/sh is very barebones it doesn't include getopts shell builtin, so we need to use a proper shell for install-sh scripts instead.

See also #35014

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg
Copy link
Contributor

dezgeg commented Feb 15, 2018

#34628 should fix this.

@abbradar
Copy link
Member Author

Ah, thanks. I suppose I'll convert this to just "cleanup".

@abbradar
Copy link
Member Author

@GrahamcOfBorg eval

I guess GitHub's target branch change is not that smooth yet :D This should cause no rebuilds (at least it does for me).

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/lj6w8wfnhag5lghp2rlvmqz0xw30jvpw-acl-2.2.52-bin
/nix/store/shqhmn4rwf93d3wj171k0m3wlgm1fy4k-attr-2.4.47-bin

@abbradar abbradar merged commit bfcb295 into NixOS:master Feb 15, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


fetching path ‘/nix/store/ps74z1b38zyqy9abqwqgp3w8cybxa7la-acl-2.2.52-bin’...

*** Downloading ‘https://nix-cache.s3.amazonaws.com/nar/0csvj8jf60psazqgz9sfkz1d19npq20mzkh85g26nsxl2xm8bbmi.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/ps74z1b38zyqy9abqwqgp3w8cybxa7la-acl-2.2.52-bin’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 23296  100 23296    0     0  23296      0  0:00:01 --:--:--  0:00:01  669k

/nix/store/ps74z1b38zyqy9abqwqgp3w8cybxa7la-acl-2.2.52-bin
/nix/store/6a5r284x0ljcnjfslx1vcnawh19jzxxi-attr-2.4.47-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

checking for references to /build in /nix/store/p46yl5ffj1x6zia8k8vn3hkpjn9s3zna-acl-2.2.52...
shrinking RPATHs of ELF executables and libraries in /nix/store/xyb6mw4qqhizfj62ss2iw7vp0i8zykz4-acl-2.2.52-man
gzipping man pages under /nix/store/xyb6mw4qqhizfj62ss2iw7vp0i8zykz4-acl-2.2.52-man/share/man/
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/xyb6mw4qqhizfj62ss2iw7vp0i8zykz4-acl-2.2.52-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/hibx18702bmwikpghiqnck7vx0asfhkg-acl-2.2.52-doc
strip is /nix/store/gfgczbs0cy0blibb0acv39cayq7qbplg-bootstrap-tools/bin/strip
checking for references to /build in /nix/store/hibx18702bmwikpghiqnck7vx0asfhkg-acl-2.2.52-doc...
/nix/store/a0lqqsfwl6ralsl77xvr9lpdn4sv97cw-acl-2.2.52-bin
/nix/store/ll7fmhmzh78hbli5pkbwwpyh1l9jm96j-attr-2.4.47-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/qiv40mb4pf2j6rz1f1g9nmh23blh94r0-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -B/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib/ -idirafter /nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/akmglc7z8hwv3sgvs9y3r6yh4a6yrglx-gcc-6.4.0-lib/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/kcl9j399w0al8rh808l2sk19xpa284mi-gmp-6.1.2-dev/include -I/nix/store/l9hznlgr5s56n25d7qqv2iiq2c20lrnf-mpfr-3.1.6-dev/include -I/nix/store/rshmv1a7pkcys6i4pj35p5vv788pchsw-libmpc-1.1.0/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/mvbh8qbdk3hs4nf73y0icdwz3z5x162r-isl-0.14.1/include  -o tree-pretty-print.o -MT tree-pretty-print.o -MMD -MP -MF ./.deps/tree-pretty-print.TPo ../../gcc-6.4.0/gcc/tree-pretty-print.c
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/qiv40mb4pf2j6rz1f1g9nmh23blh94r0-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -B/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib/ -idirafter /nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/akmglc7z8hwv3sgvs9y3r6yh4a6yrglx-gcc-6.4.0-lib/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/kcl9j399w0al8rh808l2sk19xpa284mi-gmp-6.1.2-dev/include -I/nix/store/l9hznlgr5s56n25d7qqv2iiq2c20lrnf-mpfr-3.1.6-dev/include -I/nix/store/rshmv1a7pkcys6i4pj35p5vv788pchsw-libmpc-1.1.0/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/mvbh8qbdk3hs4nf73y0icdwz3z5x162r-isl-0.14.1/include  -o tree-profile.o -MT tree-profile.o -MMD -MP -MF ./.deps/tree-profile.TPo ../../gcc-6.4.0/gcc/tree-profile.c
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/qiv40mb4pf2j6rz1f1g9nmh23blh94r0-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -B/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib/ -idirafter /nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/akmglc7z8hwv3sgvs9y3r6yh4a6yrglx-gcc-6.4.0-lib/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/kcl9j399w0al8rh808l2sk19xpa284mi-gmp-6.1.2-dev/include -I/nix/store/l9hznlgr5s56n25d7qqv2iiq2c20lrnf-mpfr-3.1.6-dev/include -I/nix/store/rshmv1a7pkcys6i4pj35p5vv788pchsw-libmpc-1.1.0/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/mvbh8qbdk3hs4nf73y0icdwz3z5x162r-isl-0.14.1/include  -o tree-scalar-evolution.o -MT tree-scalar-evolution.o -MMD -MP -MF ./.deps/tree-scalar-evolution.TPo ../../gcc-6.4.0/gcc/tree-scalar-evolution.c
/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/xg++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/./prev-gcc/ -B/nix/store/qiv40mb4pf2j6rz1f1g9nmh23blh94r0-gcc-6.4.0/x86_64-unknown-linux-gnu/bin/ -nostdinc++ -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -B/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu  -I/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include  -I/tmp/nix-build-gcc-6.4.0.drv-0/gcc-6.4.0/libstdc++-v3/libsupc++ -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs -L/tmp/nix-build-gcc-6.4.0.drv-0/build/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c   -O2 -I/nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -B/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib/ -idirafter /nix/store/jc8ir7y7q0yxi897cwf08azxkydnck86-glibc-2.26-131-dev/include -idirafter /nix/store/d1prcspbh2qsviipvnaxizcj8l3g7fpw-bootstrap-tools/lib/gcc/x86_64-unknown-linux-gnu/5.3.0/include-fixed -Wl,-rpath,/nix/store/akmglc7z8hwv3sgvs9y3r6yh4a6yrglx-gcc-6.4.0-lib/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-rpath -Wl,/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -Wl,-L/nix/store/pps4bqm7ihcmvq68ybas3x67s3kiilfd-glibc-2.26-131/lib -gtoggle -fprofile-generate -DIN_GCC     -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -I. -I. -I../../gcc-6.4.0/gcc -I../../gcc-6.4.0/gcc/. -I../../gcc-6.4.0/gcc/../include -I../../gcc-6.4.0/gcc/../libcpp/include -I/nix/store/kcl9j399w0al8rh808l2sk19xpa284mi-gmp-6.1.2-dev/include -I/nix/store/l9hznlgr5s56n25d7qqv2iiq2c20lrnf-mpfr-3.1.6-dev/include -I/nix/store/rshmv1a7pkcys6i4pj35p5vv788pchsw-libmpc-1.1.0/include  -I../../gcc-6.4.0/gcc/../libdecnumber -I../../gcc-6.4.0/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc-6.4.0/gcc/../libbacktrace -I/nix/store/mvbh8qbdk3hs4nf73y0icdwz3z5x162r-isl-0.14.1/include  -o tree-sra.o -MT tree-sra.o -MMD -MP -MF ./.deps/tree-sra.TPo ../../gcc-6.4.0/gcc/tree-sra.c
building of ‘/nix/store/673jhc7kiz6lyxiv2qyynkhn0ckyibz5-gcc-6.4.0.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/i2ggs5ny5rw4vjjj9csgsvd2bi11iiyd-gcc-wrapper-6.4.0.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/5zbbj7f2988jygjgq9f57dkfg5vfk0y6-stdenv-linux-boot.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/z0h812hg9xybwbgafgz8avlpb0s7ipg9-attr-2.4.47.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/mxbj1iz5km6ngccvw37mcki1h8x3na7n-acl-2.2.52.drv’: 2 dependencies couldn't be built
error: build of ‘/nix/store/mxbj1iz5km6ngccvw37mcki1h8x3na7n-acl-2.2.52.drv’, ‘/nix/store/z0h812hg9xybwbgafgz8avlpb0s7ipg9-attr-2.4.47.drv’ failed

@vcunat
Copy link
Member

vcunat commented Feb 15, 2018

I was just thinking for a minute or two how this diff without any rebuild could help the "motivation" in OP :-)

@abbradar
Copy link
Member Author

abbradar commented Feb 15, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants