New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodejs: Add update script #35116
nodejs: Add update script #35116
Conversation
c0f659c
to
43cf893
Compare
Success on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure I’m liking this much. Are we soon going to have hundreds of individual custom setups like this?
If at least the update logic was separate from the derivation itself, but right now that is not the case.
Bumping up a nodejs version is a matter of changing only a few lines and adjusting the sha. I don’t think the extra logic this PR introduces is worth it TBH.
Success on aarch64-linux (full log) Partial log (click to expand)
|
@gilligan This allows for updating packages using the maintainers scripts found in |
@adisbladis Yes, i get that. It’s just that i find the added boilerplate scripting going on pretty “meh”. Is that really the approach for all packages in the future? |
I guess most packages would be able to use a more generic update mechanism as described #33848. |
@adisbladis Could you remove me from the maintainer's list? I've not been maintaining this for a long time now. |
Motivation for this change
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)Made https://github.com/NixOS/nixpkgs/pull/35118/files with the scripts in this PR.
cc nodejs maintainers @goibhniu @Havvy @gilligan @cko