Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: Add update script #35116

Merged
merged 3 commits into from Mar 6, 2018
Merged

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 18, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Made https://github.com/NixOS/nixpkgs/pull/35118/files with the scripts in this PR.

cc nodejs maintainers @goibhniu @Havvy @gilligan @cko

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/06302fw8ik0nai9asn1zga64g88c2ifc-nodejs-6.12.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/0qp6kmkrx0mqyqrfj781yw3kp2wbkf7y-nodejs-6.12.3

Copy link
Contributor

@gilligan gilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure I’m liking this much. Are we soon going to have hundreds of individual custom setups like this?

If at least the update logic was separate from the derivation itself, but right now that is not the case.

Bumping up a nodejs version is a matter of changing only a few lines and adjusting the sha. I don’t think the extra logic this PR introduces is worth it TBH.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (6.70 MiB download, 32.58 MiB unpacked):
  /nix/store/g2pg448750pf27js1p5niwv831j973wv-nodejs-6.12.3
copying path '/nix/store/g2pg448750pf27js1p5niwv831j973wv-nodejs-6.12.3' from 'https://cache.nixos.org'...
/nix/store/g2pg448750pf27js1p5niwv831j973wv-nodejs-6.12.3

@adisbladis
Copy link
Member Author

@gilligan This allows for updating packages using the maintainers scripts found in maintainers/scripts/update.nix.
Using that I don't necessarily have to keep track of upstream updates.

@gilligan
Copy link
Contributor

@adisbladis Yes, i get that. It’s just that i find the added boilerplate scripting going on pretty “meh”.

Is that really the approach for all packages in the future?

@adisbladis
Copy link
Member Author

adisbladis commented Feb 23, 2018

I guess most packages would be able to use a more generic update mechanism as described #33848.
Actually come to think of it updateScript should probably be an attribute of the src.

@Havvy
Copy link
Contributor

Havvy commented Feb 23, 2018

@adisbladis Could you remove me from the maintainer's list? I've not been maintaining this for a long time now.

@adisbladis
Copy link
Member Author

@Havvy Done in e0c82dc

adisbladis added a commit that referenced this pull request Feb 27, 2018
@adisbladis adisbladis merged commit cae5a3b into NixOS:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants