Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pitivi: 0.96 → 0.99 #36201

Merged
merged 1 commit into from Apr 25, 2018
Merged

pitivi: 0.96 → 0.99 #36201

merged 1 commit into from Apr 25, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 2, 2018

Motivation for this change

Update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘pitivi-0.99’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/video/pitivi/default.nix:62 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

Wrapping program /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/bin/pitivi
shrinking RPATHs of ELF executables and libraries in /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99
shrinking /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/lib/pitivi/python/pitivi/timeline/renderer.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/lib  /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/bin 
patching script interpreter paths in /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99
/nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/bin/.pitivi-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/p1bp0kpmxi7nzrla7n7c4waqic0a2myk-python3-3.6.4/bin/python3"
checking for references to /tmp/nix-build-pitivi-0.99.drv-0 in /nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99...
wrapping `/nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99/bin/.pitivi-wrapped'...
/nix/store/nnjbfnx87h20vwsdbkyj3ii8rlk63sf6-pitivi-0.99

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

Wrapping program /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/bin/pitivi
shrinking RPATHs of ELF executables and libraries in /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99
shrinking /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/lib/pitivi/python/pitivi/timeline/renderer.so
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/lib  /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/bin
patching script interpreter paths in /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99
/nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/bin/.pitivi-wrapped: interpreter directive changed from "/usr/bin/env python3" to "/nix/store/9yr86q335k2k5ccznfcxsw0dq11zrwsw-python3-3.6.4/bin/python3"
checking for references to /build in /nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99...
wrapping `/nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99/bin/.pitivi-wrapped'...
/nix/store/8xq27hhmdmqk4pzcspkvc93jxpgxfkwz-pitivi-0.99

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 2, 2018

It looks like there is a closure contamination: https://gitlab.gnome.org/GNOME/pitivi/blob/0.99.0/meson.build#L26-37

@jtojnar jtojnar merged commit 4340a15 into NixOS:master Apr 25, 2018
@jtojnar jtojnar deleted the pitivi branch July 15, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants