Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/types: Fix coercedTo check #36638

Merged
merged 4 commits into from
May 6, 2018
Merged

lib/types: Fix coercedTo check #36638

merged 4 commits into from
May 6, 2018

Commits on Mar 9, 2018

  1. lib/types: Fix coercedTo check 

    Without this change

  (coercedTo str toInt int).check "foo"

would evaluate to true, even though

  (coercedTo str toInt int).merge {} [{ value = "foo"; }]

will throw an error because "foo" can't be coerced to an int.
    @infinisil
    infinisil committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c6cc032 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2018

  1. lib/types: Add coercedTo unsound tests

    @infinisil
    infinisil committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    dccf798 View commit details
    Browse the repository at this point in the history

  2. lib/types: clear up coercedTo description

    @infinisil
    infinisil committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    db5f8fa View commit details
    Browse the repository at this point in the history

  3. lib/types: remove unnecessary coerceFunc assertion

    @infinisil
    infinisil committed Apr 4, 2018
    Configuration menu
    Copy the full SHA
    4f5b9d7 View commit details
    Browse the repository at this point in the history