wxhexeditor: 0.22 -> 0.24

[symphorien]

Motivation for this change

ZHF: #36453

upgrading from wxGTK 2.8 to 3.1 fixes the build

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[nlewo]

@GrahamcOfBorg build wxhexeditor

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: wxhexeditor

Partial log (click to expand)

install -D -m 644 locale/tr/wxHexEditor.mo //nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24/share/locale/tr/LC_MESSAGES/wxHexEditor.mo
install -D -m 644 locale/zh_CN/wxHexEditor.mo //nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24/share/locale/zh_CN/LC_MESSAGES/wxHexEditor.mo
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24
shrinking /nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24/bin/wxHexEditor
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24/bin 
patching script interpreter paths in /nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24
checking for references to /tmp/nix-build-wxHexEditor-v0.24.drv-0 in /nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24...
/nix/store/nmfi89iiahw1np0k0d9rfwb508bdkiwx-wxHexEditor-v0.24

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: wxhexeditor

Partial log (click to expand)

             ^~~~~~~~
/nix/store/43rwn4kzfcg4i020cdmnijr7089dxk4x-wxwidgets-3.1.0/include/wx-3.1/wx/string.h:3267:13: note: candidate: wxString& wxString::operator+=(unsigned char)
   wxString& operator+=(unsigned char ch) { return *this += wxUniChar(ch); }
             ^~~~~~~~
/nix/store/43rwn4kzfcg4i020cdmnijr7089dxk4x-wxwidgets-3.1.0/include/wx-3.1/wx/string.h:3268:13: note: candidate: wxString& wxString::operator+=(wchar_t)
   wxString& operator+=(wchar_t ch) { return *this += wxUniChar(ch); }
             ^~~~~~~~
make: *** [Makefile:58: src/HexEditorCtrl/wxHexCtrl/wxHexCtrl.o] Error 1
builder for '/nix/store/wgylyy8fv1l248y3dziia504b4nsshqk-wxHexEditor-v0.24.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/wgylyy8fv1l248y3dziia504b4nsshqk-wxHexEditor-v0.24.drv' failed

[nlewo]

Could you either fix the build for aarch64-linux or set the meta.platform to x86 only?

[symphorien]

I have no aarch64 box, but I found this thread in wxHexEditor issue tracker:
EUA/wxHexEditor#90 and the associated patch.
This is exactly the error in the build log, so I have just pushed a commit with the patch, and I would like ofborg to try again building with this patch. I hope this does not count as abusing ofborg :°
If this does not work, I will stop the experiment, remove the commit and restrict platforms to x86 as you suggested.

[fpletz]

@GrahamcOfBorg build wxhexeditor

[GrahamcOfBorg]

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: wxhexeditor

No log is available.

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: wxhexeditor

Partial log (click to expand)

install -D -m 644 locale/tr/wxHexEditor.mo //nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24/share/locale/tr/LC_MESSAGES/wxHexEditor.mo
install -D -m 644 locale/zh_CN/wxHexEditor.mo //nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24/share/locale/zh_CN/LC_MESSAGES/wxHexEditor.mo
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24
shrinking /nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24/bin/wxHexEditor
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24/bin 
patching script interpreter paths in /nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24
checking for references to /tmp/nix-build-wxHexEditor-v0.24.drv-0 in /nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24...
/nix/store/rsc6vmj2m9l7qb9yzhqsmp3y185fv249-wxHexEditor-v0.24

[GrahamcOfBorg]

Success on aarch64-linux (full log)

Attempted: wxhexeditor

Partial log (click to expand)

install -D -m 644 locale/tr/wxHexEditor.mo //nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24/share/locale/tr/LC_MESSAGES/wxHexEditor.mo
install -D -m 644 locale/zh_CN/wxHexEditor.mo //nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24/share/locale/zh_CN/LC_MESSAGES/wxHexEditor.mo
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24
shrinking /nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24/bin/wxHexEditor
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24/bin
patching script interpreter paths in /nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24
checking for references to /build in /nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24...
/nix/store/wd4cdmgyyjcpj30y5vnl71nl9h05xkm8-wxHexEditor-v0.24