Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox, firefox-bin: 59.0 -> 59.0.1, firefox-esr: 52.7.1esr -> 52.7.2esr [Critical security fixes] #37208

Merged
merged 3 commits into from
Mar 18, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 17, 2018

Motivation for this change
  • Critical security fixes

https://www.mozilla.org/en-US/firefox/59.0.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2018-08/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@taku0 taku0 changed the title Firefox bin 59.0.1 firefox, firefox-bin: 59.0 -> 59.0.1, firefox-esr: 52.7.1esr -> 52.7.2esr [Critical security fixes] Mar 17, 2018
@andir
Copy link
Member

andir commented Mar 17, 2018

@GrahamcOfBorg build firefox firefox-bin firefox-esr

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: firefox, firefox-bin, firefox-esr

No log is available.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: firefox, firefox-esr

The following builds were skipped because they don't evaluate on aarch64-linux: firefox-bin

Partial log (click to expand)

glibPreFixupPhase
hicolorPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gik3sm0x56h3vxg8nflzwvy5k6dyknh2-adwaita-icon-theme-3.26.1
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/gik3sm0x56h3vxg8nflzwvy5k6dyknh2-adwaita-icon-theme-3.26.1
checking for references to /build in /nix/store/gik3sm0x56h3vxg8nflzwvy5k6dyknh2-adwaita-icon-theme-3.26.1...
cannot build derivation '/nix/store/pbh1pbcvsw3hp5654c14hyf6a8blma2f-firefox-52.7.2esr.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/8j63dshkdn1iz9klmhxhs2lizpfdll60-firefox-59.0.1.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/8j63dshkdn1iz9klmhxhs2lizpfdll60-firefox-59.0.1.drv', '/nix/store/pbh1pbcvsw3hp5654c14hyf6a8blma2f-firefox-52.7.2esr.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: firefox, firefox-esr

The following builds were skipped because they don't evaluate on x86_64-linux: firefox-bin

Partial log (click to expand)

   Compiling encoding_glue v0.1.0 (file:///build/mozilla-release-3db9e3d52b17563efca181ccbb50deb8660c59ae/intl/encoding_glue)
   Compiling cubeb-pulse v0.0.2 (file:///build/mozilla-release-3db9e3d52b17563efca181ccbb50deb8660c59ae/media/libcubeb/cubeb-pulse-rs)
   Compiling cose-c v0.1.5
   Compiling rayon v0.8.2
   Compiling mio-uds v0.6.4
   Compiling cssparser v0.23.2
   Compiling synstructure v0.5.2
building of '/nix/store/fiibz7qbkjg398idshs6jspfk2bi58ia-firefox-unwrapped-59.0.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/sl0ic04d6n7d8y9g5v7hfmd32r75ci62-firefox-59.0.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/29y49fsjcyrwhslfw97yypyhmmk72kal-firefox-52.7.2esr.drv', '/nix/store/sl0ic04d6n7d8y9g5v7hfmd32r75ci62-firefox-59.0.1.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants