-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
streamripper: Enable darwin build #37644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamripper ships its own version of libmad, which does not compile on clang, due to the usage of incompatible compiler flags. We can get the build working by using the already packaged libmad, which includes patches for clang.
GrahamcOfBorg
added
6.topic: darwin
Running or building packages on Darwin
8.has: clean-up
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
Mar 22, 2018
@GrahamcOfBorg build streamripper |
Success on x86_64-linux (full log) Attempted: streamripper Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: streamripper Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: streamripper Partial log (click to expand)
|
LnL7
approved these changes
Mar 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
8.has: clean-up
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)
streamripper ships its own version of libmad, which does not compile on
clang, due to the usage of incompatible compiler flags. We can get the
build working by using the already packaged libmad, which includes
patches for clang.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)