Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamripper: Enable darwin build #37644

Merged
merged 1 commit into from
Mar 22, 2018

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 22, 2018

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

streamripper ships its own version of libmad, which does not compile on
clang, due to the usage of incompatible compiler flags. We can get the
build working by using the already packaged libmad, which includes
patches for clang.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

streamripper ships its own version of libmad, which does not compile on
clang, due to the usage of incompatible compiler flags. We can get the
build working by using the already packaged libmad, which includes
patches for clang.
@LnL7
Copy link
Member

LnL7 commented Mar 22, 2018

@GrahamcOfBorg build streamripper

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: streamripper

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6
shrinking /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6/bin/streamripper
gzipping man pages under /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6/bin
patching script interpreter paths in /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6
checking for references to /tmp/nix-build-streamripper-1.64.6.drv-0 in /nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6...
/nix/store/d4pqk6bzhaxl0zwwgbw0ad6bqa7wrdg0-streamripper-1.64.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: streamripper

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6
shrinking /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6/bin/streamripper
gzipping man pages under /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6/bin
patching script interpreter paths in /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6
checking for references to /build in /nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6...
/nix/store/54yd0w65k228i3z0fd7xxvf2x26vzfys-streamripper-1.64.6

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: streamripper

Partial log (click to expand)

 /nix/store/s28xb9v7xf6axvf4a3av2mnczws2hsdg-coreutils-8.29/bin/install -c -m 644 './streamripper.1' '/nix/store/cbxmg72pmpsp38nb5ll04sa4qw8vjyrm-streamripper-1.64.6/share/man/man1/streamripper.1'
make[2]: Leaving directory '/private/tmp/nix-build-streamripper-1.64.6.drv-0/streamripper-1.64.6'
make[1]: Leaving directory '/private/tmp/nix-build-streamripper-1.64.6.drv-0/streamripper-1.64.6'
glibPreFixupPhase
post-installation fixup
gzipping man pages under /nix/store/cbxmg72pmpsp38nb5ll04sa4qw8vjyrm-streamripper-1.64.6/share/man/
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/cbxmg72pmpsp38nb5ll04sa4qw8vjyrm-streamripper-1.64.6/bin
patching script interpreter paths in /nix/store/cbxmg72pmpsp38nb5ll04sa4qw8vjyrm-streamripper-1.64.6
/nix/store/cbxmg72pmpsp38nb5ll04sa4qw8vjyrm-streamripper-1.64.6

@LnL7 LnL7 merged commit 1998e24 into NixOS:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants