Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gettext, libiconv: Make setup hook work for cross #37707

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Fixing my concern from https://github.com/NixOS/nixpkgs/pull/37012/files#r174660554. The method and comment is taken from the cc-wrapper and binutils-wrappers setup hooks. (Should we abstract it instead?)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

It probably needs to be done for libiconv too.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gettext

Partial log (click to expand)

/nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc/share/doc/gettext/examples/hello-tcl/autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc/share/doc/gettext/examples/hello-objc-gnome/autoclean.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc/share/doc/gettext/examples/hello-objc-gnome/autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c++-wxwidgets/autoclean.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c++-wxwidgets/autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /tmp/nix-build-gettext-0.19.8.drv-0 in /nix/store/a1jc3c16z0is4z9p9j93ivmhfh0yyx17-gettext-0.19.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/w7mlzmm2yf6mh5qkyd39jf5y1hfrijbi-gettext-0.19.8-info
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/w7mlzmm2yf6mh5qkyd39jf5y1hfrijbi-gettext-0.19.8-info
checking for references to /tmp/nix-build-gettext-0.19.8.drv-0 in /nix/store/w7mlzmm2yf6mh5qkyd39jf5y1hfrijbi-gettext-0.19.8-info...

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gettext

Partial log (click to expand)

cannot build derivation '/nix/store/ww5z4wvcn32fslr93h3alqfz06dhsaxs-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ql13sg6gr86qii2ppbpvw9pgqh9qnx7b-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/z2pcd3p6w1xbc9189h983qg5racailbh-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/pyr48mswx6mway6kcb7g32rm35pxnchr-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/jgw3s3qq6gs9lyjgvl7cfv2nkb5sdjlv-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/sfwxml4fspmpq4bg50sl8qwhn69wksgj-clang-wrapper-5.0.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/5qbwzp1ybjvysn0sqfabrc7b18qk3kjc-stdenv-darwin.drv': 35 dependencies couldn't be built
cannot build derivation '/nix/store/3wzgcr1kmycr45cc1anfj0nsm1xmw46k-libiconv-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kny31kqw6s0n0ns7avb5v4xmyk21qiwh-gettext-0.19.8.drv': 4 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/kny31kqw6s0n0ns7avb5v4xmyk21qiwh-gettext-0.19.8.drv' failed

@Ericson2314 Ericson2314 changed the title gettext: Make setup hook work for cross gettext, libiconv: Make setup hook work for cross Mar 23, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gettext, libiconv

Partial log (click to expand)

these derivations will be built:
  /nix/store/6zpfbqal2ph3905g615dfz52inc2887v-stdenv-linux.drv
  /nix/store/5774hh8l25l4v31kkvz77lpzdzyd1baa-glibc-iconv-2.27.drv
building path(s) ‘/nix/store/zx2f91p6cihy2yk1ywkg33jnyiagfnlr-stdenv-linux’
building path(s) ‘/nix/store/rk71nxcvkrlr1bavp7zic074w5blzc9i-glibc-iconv-2.27’
'/nix/store/rk71nxcvkrlr1bavp7zic074w5blzc9i-glibc-iconv-2.27/include/iconv.h' -> '/nix/store/lb3kkvyylnbcxn5jad9i11szxlhkpkjq-glibc-2.27-dev/include/iconv.h'
/nix/store/biv22ang6z5yviggwb0v2yydvsf82mgc-gettext-0.19.8
/nix/store/rk71nxcvkrlr1bavp7zic074w5blzc9i-glibc-iconv-2.27

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gettext

Partial log (click to expand)

/nix/store/ws67llkgx3ws08wrw67ixgf9qrz2j5x2-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c-gnome/autoclean.sh: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/ws67llkgx3ws08wrw67ixgf9qrz2j5x2-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c-gnome/autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/ws67llkgx3ws08wrw67ixgf9qrz2j5x2-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c/autoclean.sh: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/ws67llkgx3ws08wrw67ixgf9qrz2j5x2-gettext-0.19.8-doc/share/doc/gettext/examples/hello-c/autogen.sh: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/ws67llkgx3ws08wrw67ixgf9qrz2j5x2-gettext-0.19.8-doc...
shrinking RPATHs of ELF executables and libraries in /nix/store/8lfl5vpwwj1dvqakmw86zslaw2zhmqp6-gettext-0.19.8-info
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8lfl5vpwwj1dvqakmw86zslaw2zhmqp6-gettext-0.19.8-info
checking for references to /build in /nix/store/8lfl5vpwwj1dvqakmw86zslaw2zhmqp6-gettext-0.19.8-info...
/nix/store/6iwz2pqaaycznylbi38vk0yk2fhyvh3s-gettext-0.19.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gettext, libiconv

Partial log (click to expand)

  /nix/store/v4rdagdy1dp425fkgf22dczyipririi0-stdenv-linux.drv
  /nix/store/b0c4kpl4m2m1ipr3bbpnw0iqzgykxar9-glibc-iconv-2.27.drv
  /nix/store/xxij5i8442pgk27pjf8s08iz2kw1nrfq-stdenv-linux.drv
  /nix/store/dldrd0havh0z29j3n1j771akr2nb40cg-gettext-0.19.8.drv
waiting for locks or build slots...
building '/nix/store/v4rdagdy1dp425fkgf22dczyipririi0-stdenv-linux.drv'...
building '/nix/store/b0c4kpl4m2m1ipr3bbpnw0iqzgykxar9-glibc-iconv-2.27.drv'...
'/nix/store/65bywak8rpbzmrdx0za6g86219x6szd7-glibc-iconv-2.27/include/iconv.h' -> '/nix/store/cvrbvx0jrcv7m4qim0332p2x9xzgkk30-glibc-2.27-dev/include/iconv.h'
/nix/store/6iwz2pqaaycznylbi38vk0yk2fhyvh3s-gettext-0.19.8
/nix/store/65bywak8rpbzmrdx0za6g86219x6szd7-glibc-iconv-2.27

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: gettext, libiconv

Partial log (click to expand)

cannot build derivation '/nix/store/j8ihdxvghbd8nyrbgrmnpb3ycizx0fcc-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/k0zd8xqdiyc67rmaz2krkdkvvz18c432-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/3si0wbqic2qflpbwg7mwajgmvlv6048a-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ixz0ig00m3r7b4jljq4hmxrhbra7xpbq-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/hbg7l93dfvjyj2rgc6q9p84ks8fah3lp-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/mvzffxl97h5x10y8i49n5japbiylpkna-clang-wrapper-5.0.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/8531jnav21xjamn3rd6210k6sr4fyn1f-stdenv-darwin.drv': 35 dependencies couldn't be built
cannot build derivation '/nix/store/h7inv3dv6hjfpx3d09kgfzv0djzjn272-libiconv-osx-10.11.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/agw215vaqbqd9zkvadrf0zzsm53r1598-gettext-0.19.8.drv': 4 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/agw215vaqbqd9zkvadrf0zzsm53r1598-gettext-0.19.8.drv', '/nix/store/h7inv3dv6hjfpx3d09kgfzv0djzjn272-libiconv-osx-10.11.6.drv' failed

@Ericson2314 Ericson2314 merged commit 5d11625 into NixOS:staging Mar 23, 2018
@Ericson2314 Ericson2314 deleted the gettext-setup-hook-cross branch March 23, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants