Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"libiconv" fixes re:musl #37835

Merged
merged 3 commits into from
Mar 26, 2018
Merged

"libiconv" fixes re:musl #37835

merged 3 commits into from
Mar 26, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 26, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gettext, glib

The following builds were skipped because they don't evaluate on x86_64-darwin: man-db

Partial log (click to expand)

to ~/.config/nixpkgs/config.nix.


these paths will be fetched (3.81 MiB download, 19.39 MiB unpacked):
  /nix/store/20pwll8n93nman9111ijcijj6ym9g5ms-gettext-0.19.8
  /nix/store/3268906wlw844pycghcf2npcb40nkafj-glib-2.56.0
copying path '/nix/store/20pwll8n93nman9111ijcijj6ym9g5ms-gettext-0.19.8' from 'https://cache.nixos.org'...
copying path '/nix/store/3268906wlw844pycghcf2npcb40nkafj-glib-2.56.0' from 'https://cache.nixos.org'...
/nix/store/20pwll8n93nman9111ijcijj6ym9g5ms-gettext-0.19.8
/nix/store/3268906wlw844pycghcf2npcb40nkafj-glib-2.56.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gettext, glib, man-db

Partial log (click to expand)

gzipping man pages under /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/lib  /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/libexec  /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/bin  /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/sbin
patching script interpreter paths in /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5
checking for references to /build in /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5...
moving /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/sbin/* to /nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/fg7lg9wdv8v9l272pf0pm5mqwq38svll-man-db-2.7.5-doc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/fg7lg9wdv8v9l272pf0pm5mqwq38svll-man-db-2.7.5-doc
checking for references to /build in /nix/store/fg7lg9wdv8v9l272pf0pm5mqwq38svll-man-db-2.7.5-doc...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gettext, glib, man-db

Partial log (click to expand)

patching script interpreter paths in /nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5
checking for references to /build in /nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5...
moving /nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5/sbin/* to /nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5/bin
shrinking RPATHs of ELF executables and libraries in /nix/store/qaikhsl0mpn5iwls9k4kvja5qrs9yx1h-man-db-2.7.5-doc
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/qaikhsl0mpn5iwls9k4kvja5qrs9yx1h-man-db-2.7.5-doc
checking for references to /build in /nix/store/qaikhsl0mpn5iwls9k4kvja5qrs9yx1h-man-db-2.7.5-doc...
/nix/store/6iwz2pqaaycznylbi38vk0yk2fhyvh3s-gettext-0.19.8
/nix/store/hxf2ldpzrj1a0an7ln8k2bgcllw76jzl-glib-2.56.0
/nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5

@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2018

First commit may no longer help, testing to be sure now.

EDIT: yep, removed.

@dtzWill dtzWill merged commit 01b254e into NixOS:staging Mar 26, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: glib

The following builds were skipped because they don't evaluate on x86_64-darwin: man-db

Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


/nix/store/3268906wlw844pycghcf2npcb40nkafj-glib-2.56.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: glib, man-db

Partial log (click to expand)

/nix/store/nrqy975686ydw4s2vi66cpvb1wnc35qk-glib-2.56.0
/nix/store/hbn5id81nwbzzk4b8f8cq0fglhgs4y3i-man-db-2.7.5

@dtzWill dtzWill deleted the fix/musl-libiconv branch March 26, 2018 04:49
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: glib, man-db

Partial log (click to expand)

patching script interpreter paths in /nix/store/pgvg4azmr4983lckrrqlzc5fx1p8jm4r-glib-2.56.0-dev
/nix/store/pgvg4azmr4983lckrrqlzc5fx1p8jm4r-glib-2.56.0-dev/bin/glib-gettextize: interpreter directive changed from " /bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/pgvg4azmr4983lckrrqlzc5fx1p8jm4r-glib-2.56.0-dev/bin/gdbus-codegen: interpreter directive changed from "/usr/bin/env /nix/store/xgnn5sg4d86d4ip7frpp3fp5gmh298wi-python-2.7.14/bin/python" to "/nix/store/xgnn5sg4d86d4ip7frpp3fp5gmh298wi-python-2.7.14/bin/python"
checking for references to /build in /nix/store/pgvg4azmr4983lckrrqlzc5fx1p8jm4r-glib-2.56.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/72lmghrxf48hj5chnmczlnrg3vdais2x-glib-2.56.0-devdoc
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/72lmghrxf48hj5chnmczlnrg3vdais2x-glib-2.56.0-devdoc
checking for references to /build in /nix/store/72lmghrxf48hj5chnmczlnrg3vdais2x-glib-2.56.0-devdoc...
/nix/store/hxf2ldpzrj1a0an7ln8k2bgcllw76jzl-glib-2.56.0
/nix/store/79c4a4yhlq72sayw3i98rf5r22j3qs35-man-db-2.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants