-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove placeholder usage #37860
Conversation
I did not yet have time to test if it works (webkitgtk rebuild). |
IMO we should just merge this immediately and test it through Hydra. The |
Apparently, at least libgee was broken by this. |
Okay, all the packages seem to build and the executables run. |
@infinisil does it matter? It is only used by mutter. Who would be using unstable desktop but outdated Nix? |
Yes, it matters for evaluation. |
@jtojnar nixpkgs is used by many people that aren't using NixOS, and they should be able to use mutter and pipewire too (without having to update to latest Nix). Nix and nixpkgs should mostly stay forwards and backwards compatible |
Is not evaluation lazy? Anyway, this broke |
Yeah evaluation is lazy if you are using |
Awesome thanks! |
Temporary compatibility fix, continuation of #37860
Motivation for this change
I keep forgetting 17.03 is not released yet, see 2abac54
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)