Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove placeholder usage #37860

Merged
merged 1 commit into from Mar 27, 2018
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Mar 26, 2018

Motivation for this change

I keep forgetting 17.03 is not released yet, see 2abac54

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Mar 26, 2018
@matthewbauer
Copy link
Member

@jtojnar Can this be merged? Lots of people have been complaining about some variation of this.

Can probably end up closing #37875 with this.

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 27, 2018

I did not yet have time to test if it works (webkitgtk rebuild).

@matthewbauer
Copy link
Member

matthewbauer commented Mar 27, 2018

IMO we should just merge this immediately and test it through Hydra. The placeholder usage means that evaluation is broken for Nix 1.11 users which is pretty critical (and means they can't upgrade even if they want to).

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 27, 2018

Apparently, at least libgee was broken by this.

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 27, 2018

Okay, all the packages seem to build and the executables run.

@jtojnar jtojnar merged commit 82f6267 into NixOS:master Mar 27, 2018
@infinisil
Copy link
Member

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 28, 2018

@infinisil does it matter? It is only used by mutter. Who would be using unstable desktop but outdated Nix?

@jtojnar jtojnar deleted the unplaceholder branch March 28, 2018 16:22
@LnL7
Copy link
Member

LnL7 commented Mar 28, 2018

Yes, it matters for evaluation.

@infinisil
Copy link
Member

infinisil commented Mar 28, 2018

@jtojnar nixpkgs is used by many people that aren't using NixOS, and they should be able to use mutter and pipewire too (without having to update to latest Nix). Nix and nixpkgs should mostly stay forwards and backwards compatible

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 28, 2018

Is not evaluation lazy? Anyway, this broke evolution-data-server, will push a fix for both shortly.

@matthewbauer
Copy link
Member

Yeah evaluation is lazy if you are using nix-env -iA. Unfortunately lots of people are still in the habit of using nix-env -i. Since it's still supported we aim to not break evaluation (although this is a special case because it will evaluate under Nix 2.0 which OfBorg and Hydra are on).

@jtojnar
Copy link
Contributor Author

jtojnar commented Mar 28, 2018

Fix pushed, including the one for #36978: 025881c

@matthewbauer
Copy link
Member

Awesome thanks!

jtojnar added a commit that referenced this pull request Mar 28, 2018
Temporary compatibility fix, continuation of #37860
@github-actions github-actions bot removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants