Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parted: add missing fnctl include, fix w/musl #37933

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 27, 2018

Disable tests on musl, maybe fix or refine this in the future.

Depends on being able to build sytemd w/musl in order to build/test,
but fixing this is part of upstreaming fixes that make it possible
to test systemd-musl via NixOS tests.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Disable tests on musl, maybe fix or refine this in the future.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: parted

Partial log (click to expand)

these paths will be fetched (0.42 MiB download, 2.08 MiB unpacked):
  /nix/store/ifpnh41rpy7zbbnmph3dzal423pl8ji6-parted-3.2
copying path '/nix/store/ifpnh41rpy7zbbnmph3dzal423pl8ji6-parted-3.2' from 'https://cache.nixos.org'...
/nix/store/ifpnh41rpy7zbbnmph3dzal423pl8ji6-parted-3.2

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: parted

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: parted

Partial log (click to expand)

[626/1461] Compiling C object 'systemd-rfkill@exe/src_rfkill_rfkill.c.o'.
[627/1461] Compiling C object 'systemd-localed@exe/src_locale_keymap-util.c.o'.
[628/1461] Compiling C object 'bootctl@exe/src_boot_bootctl.c.o'.
[629/1461] Compiling C object 'systemctl@exe/src_systemctl_systemctl.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/nhsk0sjbx5cn02jprnbydc6ix5sxd1w0-systemd-238.drv' failed with exit code 1
cannot build derivation '/nix/store/fy9jx9fyxil3p6cjnwsh5slvg6ik2qwd-util-linux-2.31.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/vhw815lccdj83igkvb13m383idkaw30f-lvm2-2.02.177.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0plra9p8d9ihdnly027s6bps005c8pfy-parted-3.2.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/0plra9p8d9ihdnly027s6bps005c8pfy-parted-3.2.drv' failed

@dtzWill dtzWill merged commit 9c4745f into NixOS:staging Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants