Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setupcfg2nix and supporting infrastructure #38778

Merged
merged 1 commit into from
Apr 11, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions pkgs/build-support/build-setupcfg/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Build a python package from info made available by setupcfg2nix.
#
# * src: The source of the package.
# * info: The package information generated by setupcfg2nix.
# * meta: Standard nixpkgs metadata.
# * application: Whether this package is a python library or an
# application which happens to be written in python.
pythonPackages: { src, info, meta ? {}, application ? false }: let
build = if application
then pythonPackages.buildPythonApplication
else pythonPackages.buildPythonPackage;
in build {
inherit (info) pname version;

inherit src meta;

nativeBuildInputs = map (p: pythonPackages.${p}) (
(info.setup_requires or []) ++
(info.tests_require or []));

propagatedBuildInputs = map (p: pythonPackages.${p})
(info.install_requires or []);
}
19 changes: 19 additions & 0 deletions pkgs/development/tools/setupcfg2nix/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{ buildSetupcfg, fetchFromGitHub, lib }:

buildSetupcfg rec {
info = import ./info.nix;
src = fetchFromGitHub {
owner = "target";
repo = "setupcfg2nix";
rev = info.version;
sha256 = "1zn9njpzwhwikrirgjlyz6ys3xr8gq61ry8blmnpscqvhsdhxcs6";
};
application = true;
meta = {
description = "Generate nix expressions from setup.cfg for a python package.";
homepage = https://github.com/target/setupcfg2nix;
license = lib.licenses.mit;
platforms = lib.platforms.all;
maintainers = [ lib.maintainers.shlevy ];
};
}
7 changes: 7 additions & 0 deletions pkgs/development/tools/setupcfg2nix/info.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
pname = ''setupcfg2nix'';
version = ''1.1.0'';
install_requires = [
''setuptools''
];
}
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7230,6 +7230,8 @@ with pkgs;
pythonPackages = python3Packages;
};

setupcfg2nix = python3Packages.callPackage ../development/tools/setupcfg2nix {};

# These pyside tools do not provide any Python modules and are meant to be here.
# See ../development/python-modules/pyside/default.nix for details.
pysideApiextractor = callPackage ../development/python-modules/pyside/apiextractor.nix { };
Expand Down
4 changes: 4 additions & 0 deletions pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ let
toPythonModule = x: x; # Application does not provide modules.
}));

# See build-setupcfg/default.nix for documentation.
buildSetupcfg = import ../build-support/build-setupcfg self;

graphiteVersion = "1.0.2";

fetchPypi = makeOverridable( {format ? "setuptools", ... } @attrs:
Expand Down Expand Up @@ -133,6 +136,7 @@ in {
inherit fetchPypi callPackage;
inherit hasPythonModule requiredPythonModules makePythonPath disabledIf;
inherit toPythonModule toPythonApplication;
inherit buildSetupcfg;

# helpers

Expand Down