New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixtools.modprobe: fix #38860
unixtools.modprobe: fix #38860
Conversation
Isn't modprobe a Linux-specific binary anyways? It shouldn't need any abstraction. |
Thanks! |
Right now that's mostly true. It is still useful for shell scripts, etc. that only need "modprobe" or other tools. Also, most people don't know that "kmod" provides userspace modprobe - so having it here is an easy way for users to fix "modprobe not found" errors. Definitely will wait before these commands make sense tree wide. |
Success on x86_64-linux (full log) Attempted: unixtools.modprobe Partial log (click to expand)
|
I think adding Linux-only commands to |
Success on aarch64-linux (full log) Attempted: unixtools.modprobe Partial log (click to expand)
|
I somewhat agree- although there are some binaries where it's not exactly clear if they are truly Linux-only. For instance, all of these only have Linux versions:
I think modprobe is the only one that is truly Linux only. |
And of course modprobe also has analogs on other platforms. But what is the point of having |
I guess the main point of unixtools is to just provide Unix-standardized tools that should be available in every Unixy platform. Mostly, I want to get rid of all of the Right now, everything in Linux should stay the same. "utillinux", "nettools", and "procps" will have all of the binaries they have always had (in Linux at least- Darwin uses unixtools versions) . Eventually I want to break some of these scripts, but the initial PR was just to provide the above. I was probably too quick in adding modprobe. I didn't realize that Linux was the only system that had it. |
I was probably too quick in adding modprobe. I didn't realize that Linux was the only system that had it.
Maybe every command should always have at least two implementations? Because otherwise why bother adding it.
|
Interestingly, autofs had always taken modprobe from utillinux: 3e84cbc |
logger, mount, umount and wall are all specified in POSIX, so I'm pretty certain there will be other implementations of those :). |
Which is why it is bad to add them to |
Motivation for this change
There's no
modprobe
inutillinux
./cc @matthewbauer
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)